Repository navigation
Conversation
Contributor
|
You can access the deployment of this PR at https://renku-ci-ds-1462.dev.renku.ch |
wesjdj
force-pushed
the
spot-jobs-priority
branch
from
September 30, 2026 09:53
c8cc2b8 to
f76fdb9
Compare
Coverage Report for CI Build 38225780506Coverage decreased (-0.05%) to 85.215%Details
Uncovered Changes
Coverage Regressions13 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
wesjdj
marked this pull request as ready for review
October 9, 2026 13:33
wesjdj
force-pushed
the
spot-jobs-priority
branch
from
October 9, 2026 13:40
a3217c2 to
52e1237
Compare
This was referenced Oct 9, 2026
Closed
-10 is exactly the default cluster-autoscaler expendable-pods-priority-cutoff. -5 keeps preemptible pods below placeholders and sessions, with a margin above the cutoff so they still trigger a scale-up.
wesjdj
force-pushed
the
spot-jobs-priority
branch
from
October 15, 2026 08:47
1ac46d4 to
a75df8f
Compare
leafty
reviewed
Oct 15, 2026
Comment on lines
+183
to
+185
| def pool_preemptible_priority_class_name(namespace: str, resource_pool_id: int) -> str: | ||
| """Return the name of the priority class for the preemptible resource classes of a pool without a quota.""" | ||
| return f"{namespace}-pool-{resource_pool_id}-preemptible" |
Member
There was a problem hiding this comment.
Would it be simpler to not allow preemptible when the parent resource pool has no quota?
leafty
reviewed
Oct 15, 2026
| example: true | ||
| Preemptible: | ||
| type: boolean | ||
| description: Whether sessions and jobs in this resource class can be preempted by resources in non-preemptible resource classes |
Member
There was a problem hiding this comment.
Suggested change
| description: Whether sessions and jobs in this resource class can be preempted by resources in non-preemptible resource classes | |
| description: Whether sessions and jobs in this resource class can be preempted by other workloads |
Also, can apps be run as preemptible?
Comment on lines
+1914
to
+1915
| SESSION_PRIORITY_VALUE = 100 | ||
| PREEMPTIBLE_PRIORITY_VALUE = -5 |
Member
There was a problem hiding this comment.
Nicer: move these to constants.py and add a short docstring.
Comment on lines
+1306
to
+1307
| labels["renku.io/preemptible"] = str(resource_class.preemptible).lower() | ||
|
|
Member
There was a problem hiding this comment.
Move this to when labels is created (L1292).
Comment on lines
+1086
to
+1089
| if resource_class.preemptible: | ||
| await rp_repo.quotas_repo.ensure_preemptible_priority_class( | ||
| resource_pool.id, resource_class.quota, resource_pool.get_cluster_id() | ||
| ) |
Member
There was a problem hiding this comment.
Creating the priority class should not happen at session start or session patch.
Suggested change
| if resource_class.preemptible: | |
| await rp_repo.quotas_repo.ensure_preemptible_priority_class( | |
| resource_pool.id, resource_class.quota, resource_pool.get_cluster_id() | |
| ) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a preemptible flag on resource classes, so jobs in those classes can run on spot nodes and be evicted by sessions; also fixes #1422. Needs SwissDataScienceCenter/renku#4640 (data-tasks RBAC); retry on eviction is in SwissDataScienceCenter/amalthea#1237.
/deploy #notest amalthea-sessions=spot-jobs-disruption renku=spot-jobs-rbac