Resolved the issue in the wishlist - #20
Merged
Merged
Conversation
14-Prasanna
requested review from
Rishwanth-Adhishwar,
TAMILKUMAR0027,
Copilot,
raviravi31799-crypto and
samihamuhabathulla-jpg
June 12, 2026 06:20
TAMILKUMAR0027
requested changes
Jun 12, 2026
TAMILKUMAR0027
left a comment
TAMILKUMAR0027
left a comment
Owner
There was a problem hiding this comment.
Put config.ini file in the gitignore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
PR Information
Team Information
Related Issue
Fixes #
Closes #
Summary
Implements wishlist automation test suite covering add/remove product flows (via home page, top collection, and search), fixes
WishListActions/BaseActionintegration issues, adds post-login home page navigation, and introduces structured logging across wishlist actions and tests.Detailed Changes
Added
actions/wishlist_actions.py—WishListActionsclass with methods to add/remove products, navigate wishlist, handle success/removal messages, and return to home page after login.tests/test_wishlist.py— Test suite for adding single/multiple products, adding via search, and removing single/multiple products from wishlist.actions/launch_actions.py—LaunchActionsclass for homepage verification (URL, title, logo).tests/test_home.py— Smoke test for homepage launch verification.utils/loggerCreator.get_loggeracross wishlist actions and tests.Modified
pages/wishlist_page.py— Centralized locators for wishlist-related elements.tests/test_wishlist.py— Updated login flow to reuseHomePageAction,LoginPageAction,AccountPageActionfrom existing login tests; replaced hardcoded credentials with Excel data provider.Removed
BaseActionimport and constructor mismatch (driver, wait→driver).Refactored
WishListActions.__init__aligned withBaseAction(driver)signature.ExceptionwithRuntimeErrorfor unexpected alerts._assert_success_message,_assert_removal_message,_ensure_product_in_wishlisthelper functions to reduce duplication in tests.Type of Change
Testing Performed
Pytest Execution
Browsers Tested
Evidence
Test execution logs available at
logs/logs.log. Console output confirms successful login, home page navigation, and wishlist add/remove flows foriMac,Apple Cinema 30,iPod Nano, andiPod Shuffle.Configuration Changes
Impact Analysis
Affected Modules:
actions/wishlist_actions.pytests/test_wishlist.pypages/wishlist_page.pyPotential Risks:
Rollback Plan:
WishListActionsimplementation and test file; no shared/global modules were altered.Checklist
Code Quality
Testing
Documentation
CI/CD
Reviewer Notes
Special instructions for reviewers:
HOME_PAGE_URLconstant matches the environment-specific base URL before merging to other environments.Final Approval