Fixes a circular import error between pages/launch.py and actions/launch_actions.py - #22
Merged
Conversation
…tween Launch.py and launch_action.py
14-Prasanna
requested review from
Rishwanth-Adhishwar,
TAMILKUMAR0027,
raviravi31799-crypto and
samihamuhabathulla-jpg
June 12, 2026 06:49
TAMILKUMAR0027
approved these changes
Jun 12, 2026
TAMILKUMAR0027
left a comment
TAMILKUMAR0027
left a comment
Owner
There was a problem hiding this comment.
Nice Prasanna Issue is resolved
Rishwanth-Adhishwar
approved these changes
Jun 12, 2026
Rishwanth-Adhishwar
left a comment
Rishwanth-Adhishwar
left a comment
Collaborator
There was a problem hiding this comment.
Noted,You Removed LaunchPageAction in Pgaes
14-Prasanna
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
PR Information
Team Information
Related Issue
Fixes #
Closes #
Summary
Fixes a circular import error between
pages/launch.pyandactions/launch_actions.pythat was causing collection errors fortests/test_launch.pyandtests/test_login.py.pages/launch.pyno longer imports fromactions/, restoring correct page-object/action separation.Detailed Changes
Added
LaunchPages.get_current_url,get_page_title,get_logomethods inpages/launch.py.Modified
pages/launch.py— removed invalidfrom actions.launch_actions import LaunchActionsimport that caused a circular dependency withactions/launch_actions.py.Removed
pages/launch.pyandactions/launch_actions.py.Refactored
pages/launch.pynow contains only locators and element accessors (no action-layer imports), per POM convention.Type of Change
Testing Performed
Pytest Execution
Browsers Tested
Evidence
pytest -s -m smokeandpytest -s -m Prasannaexecuted successfully —test_launch.py::TestHome::test_homepage_verificationandtest_login.pycollect and pass with no import errors.Configuration Changes
Impact Analysis
Affected Modules:
pages/launch.pyactions/launch_actions.pytests/test_launch.pyPotential Risks:
Rollback Plan:
pages/launch.py; note the previous version had a collection-blocking circular import, so rollback would reintroduce that failure.Checklist
Code Quality
Testing
Documentation
CI/CD
Reviewer Notes
Special instructions for reviewers:
pages/imports fromactions/to prevent similar circular import issues.Final Approval