Skip to content

Commit 1ea56e5

Browse files
authored
fix: mt7925-tune.py status only printing the AQL table header (#155)
Found from a real run on the target hardware (G16 GA605WV): `status` showed ``` -- AQL Best Effort queue limit -- AC AQL limit low AQL limit high ``` with none of the actual per-access-category values below it. ## Type of change - [x] `fix`: bug fix (broken link, incorrect command, layout issue) ## Details `aql_txq_limit` in debugfs is a header line plus one row per access category (VO/VI/BE/BK), not a single value. The status parsing kept only `aql_lines[1]` -- the header row -- and silently dropped the rest of the table, including the row that actually shows whether the tuning took effect. Fix: join every line after the `EXISTS`/`MISSING` marker instead of taking just the second one, so the full table prints (matching what a plain `cat aql_txq_limit` would show). Verified the parsing logic against a realistic multi-line debugfs dump (header + 4 AC rows) in isolation, since this sandbox has no `iw`/wireless hardware to exercise the real path end-to-end. Recomputed and republished the checksum in both docs pages. ## Checklist - [x] PR title follows the commit convention - [x] Both EN and NL versions updated (checksum only, no content changes) - [x] Media is in AVIF format (not PNG/JPG) — N/A - [x] No broken image references — N/A - [x] Tested locally: compiles.
1 parent f5c6e4b commit 1ea56e5

3 files changed

Lines changed: 7 additions & 5 deletions

File tree

src/content/docs/networking/mt7925-wifi-performance.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Test conditions, since they affect the numbers: a UniFi U7 Pro access point, in
2323

2424
```bash
2525
curl -LO https://zephyrus-linux.thectic.nl/scripts/mt7925-tune.py
26-
echo "1da15474e447e1fe98872072768dd5f148c0a632ae39f78fc5b5b8ae3fa1e534 mt7925-tune.py" | sha256sum -c
26+
echo "cf5aa114d872c6480525b55f637fab346337f9cbbdce9657e0688fd48cac1247 mt7925-tune.py" | sha256sum -c
2727
```
2828

2929
### Apply
@@ -42,7 +42,7 @@ python3 mt7925-tune.py enable --bluetooth-off
4242

4343
{{% /steps %}}
4444

45-
Source: [mt7925-tune.py](/scripts/mt7925-tune.py). SHA-256 `1da15474e447e1fe98872072768dd5f148c0a632ae39f78fc5b5b8ae3fa1e534`.
45+
Source: [mt7925-tune.py](/scripts/mt7925-tune.py). SHA-256 `cf5aa114d872c6480525b55f637fab346337f9cbbdce9657e0688fd48cac1247`.
4646

4747
| Fix (applied by `enable`) | What it does |
4848
|---|---|

src/content/docs/networking/mt7925-wifi-performance.nl.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Testomstandigheden, want die beïnvloeden de cijfers: een UniFi U7 Pro access po
2323

2424
```bash
2525
curl -LO https://zephyrus-linux.thectic.nl/scripts/mt7925-tune.py
26-
echo "1da15474e447e1fe98872072768dd5f148c0a632ae39f78fc5b5b8ae3fa1e534 mt7925-tune.py" | sha256sum -c
26+
echo "cf5aa114d872c6480525b55f637fab346337f9cbbdce9657e0688fd48cac1247 mt7925-tune.py" | sha256sum -c
2727
```
2828

2929
### Toepassen
@@ -42,7 +42,7 @@ python3 mt7925-tune.py enable --bluetooth-off
4242

4343
{{% /steps %}}
4444

45-
Bron: [mt7925-tune.py](/scripts/mt7925-tune.py). SHA-256 `1da15474e447e1fe98872072768dd5f148c0a632ae39f78fc5b5b8ae3fa1e534`.
45+
Bron: [mt7925-tune.py](/scripts/mt7925-tune.py). SHA-256 `cf5aa114d872c6480525b55f637fab346337f9cbbdce9657e0688fd48cac1247`.
4646

4747
| Fix (toegepast door `enable`) | Wat het doet |
4848
|---|---|

src/static/scripts/mt7925-tune.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,9 @@ def _read_privileged_status(self, aql: Path) -> dict[str, object]:
372372
dmesg_part, _, aql_part = res.stdout.partition(marker + "\n")
373373
aql_lines = aql_part.splitlines()
374374
exists = bool(aql_lines) and aql_lines[0].strip() == "EXISTS"
375-
value = aql_lines[1].strip() if exists and len(aql_lines) > 1 else ""
375+
# aql_txq_limit is a header line plus one row per access category
376+
# (VO/VI/BE/BK), not a single value -- keep the whole table.
377+
value = "\n".join(aql_lines[1:]).strip() if exists and len(aql_lines) > 1 else ""
376378
return {"dmesg": dmesg_part, "aql_exists": exists, "aql_value": value}
377379

378380
@staticmethod

0 commit comments

Comments
 (0)