Skip to content

Commit 290d4e8

Browse files
committed
Prefer splitting inline
1 parent aa95c37 commit 290d4e8

1 file changed

Lines changed: 7 additions & 7 deletions

File tree

tivars/flash.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@
44

55

66
from io import BytesIO
7+
from string import hexdigits
78
from sys import version_info
89
from typing import BinaryIO
910
from warnings import warn
10-
from string import hexdigits
1111

1212
from .data import *
1313
from .file import *
@@ -328,11 +328,6 @@ def dict(self, **kwargs) -> dict:
328328
"dataHex": self.data.hex().upper()
329329
}
330330

331-
def split_intelhex(data):
332-
for i, c in enumerate(data):
333-
if chr(c) == ':' and chr(data[i+1]) in hexdigits:
334-
yield data[i:]
335-
336331
class FlashData(Converter[bytes | list[TIFlashBlock]]):
337332
"""
338333
Converter to split flash data into blocks if stored in Intel format
@@ -352,7 +347,12 @@ def get(cls, data: bytes, *, instance=None) -> bytes | list[TIFlashBlock]:
352347
"""
353348

354349
if instance is None or instance.binary_flag == 0x01:
355-
return list(map(TIFlashBlock, split_intelhex(data)))
350+
intelhex = []
351+
for i, c in enumerate(data):
352+
if chr(c) == ':' and chr(data[i + 1]) in hexdigits:
353+
intelhex.append(TIFlashBlock(data[i:]))
354+
355+
return intelhex
356356

357357
else:
358358
return data

0 commit comments

Comments
 (0)