Repository navigation
Commit 0471ac6
fix(skills): name the silent bake failure and check the bake result (#429)
bake-high-to-low said a missing UV layer or a non-active image node
"finishes without error". Measured on 4.5.11 LTS and 5.2.1 LTS: a
missing UV layer raises RuntimeError, a lone Image Texture node that is
not nodes.active is baked into anyway, and the case that really is
silent is a material with no Image Texture node, which returns
{'CANCELLED'} and raises nothing. The canonical call assigned `result`
and never looked at it.
The skill now tabulates the three measured behaviours, and both the
skill's canonical call and snippets/bake_normal_high_to_low.py raise
when the result is not {'FINISHED'}.
Closes #356
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>1 parent f30667e commit 0471ac6
2 files changed
Lines changed: 18 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
22 | | - | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
23 | 31 | | |
24 | 32 | | |
25 | 33 | | |
| |||
104 | 112 | | |
105 | 113 | | |
106 | 114 | | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
107 | 118 | | |
108 | 119 | | |
109 | 120 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
| |||
18 | 20 | | |
19 | 21 | | |
20 | 22 | | |
21 | | - | |
| 23 | + | |
22 | 24 | | |
23 | 25 | | |
24 | 26 | | |
| |||
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
0 commit comments