You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 137045a
Browse filesBrowse the repository at this point in the historyBrowse files
fix: wave-displace presentation, the wave as a tile on the studio floor
Render path only: a skirted copy of the checked grid stands on the floor
instead of bleeding off three frame edges. Contract and exit codes
unchanged on 4.5.11, 5.1.2 and 5.2.1.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Copy file name to clipboardExpand all lines: README.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -361,7 +361,7 @@ then re-reads its own render and fails unless the pixels prove the flat-vs-check
361
361
</tr>
362
362
<tr>
363
363
<tdwidth="46%"valign="middle">
364
-
<ahref="examples/wave-displace/"><imgsrc="examples/wave-displace/preview.webp"alt="Wave displace: a glossy sapphire-blue surface displaced into smooth standing-wave dunes against a black backdrop" /></a>
364
+
<ahref="examples/wave-displace/"><imgsrc="examples/wave-displace/preview.webp"alt="Wave displace: a sapphire-blue tile whose top is displaced into smooth standing-wave dunes, standing on a dark studio floor" /></a>
<metaname="twitter:description" content="Bulk vertex IO at real scale — 9,409 vertices displaced into a standing wave with one foreach_get and one foreach_set, no per-vertex access." />
<p>Bulk vertex IO at real scale — 9,409 vertices displaced into a standing wave with one foreach_get and one foreach_set, no per-vertex access.</p>
269
269
</header>
270
270
<mainid="main">
271
-
<buttonclass="detail-hero" id="heroZoom" type="button" aria-label="View full size: A blue grid surface displaced into rolling sine-wave hills.">
272
-
<imgsrc="../assets/wave-displace-hero.webp" alt="A blue grid surface displaced into rolling sine-wave hills." width="1280" height="720" />
271
+
<buttonclass="detail-hero" id="heroZoom" type="button" aria-label="View full size: A blue tile whose top is a grid displaced into rolling sine-wave hills, standing on a dark studio floor.">
272
+
<imgsrc="../assets/wave-displace-hero.webp" alt="A blue tile whose top is a grid displaced into rolling sine-wave hills, standing on a dark studio floor." width="1280" height="720" />
273
273
</button>
274
274
<pclass="zoom-hint">Rendered headless by the example itself — click to zoom.</p>
275
275
<divclass="callout"><spanclass="tag">witnesses</span> The bulk path is correct, not just fast: the Z span matches the wave amplitude and every vertex matches the closed-form wave, so a stride bug in the flat buffer cannot hide.</div>
@@ -280,8 +280,9 @@ <h1>wave-displace</h1>
280
280
<sectionclass="detail-section md">
281
281
<p>A runnable example that displaces a 96×96 grid (9,409 vertices) into a standing wave using <strong>one <code>foreach_get</code> and one <code>foreach_set</code></strong> — the bulk-IO pattern from <ahref="https://github.com/TMHSDigital/Blender-Developer-Tools/tree/main/rules/use-foreach-set-for-bulk-data.mdc"><code>use-foreach-set-for-bulk-data</code></a> and the <ahref="https://github.com/TMHSDigital/Blender-Developer-Tools/tree/main/skills/mesh-editing-and-bmesh/SKILL.md"><code>mesh-editing-and-bmesh</code></a> skill — instead of 9,409 individual <code>mesh.vertices[i].co</code> accesses.</p>
282
282
<p><strong>What it witnesses:</strong> the bulk path is not just faster, it is <em>correct</em> — the check asserts the flat grid gained the expected Z span (the write actually landed) and that <strong>every</strong> vertex matches the closed-form wave, so a stride or interleave bug in the flat buffer cannot hide behind a lucky probe.</p>
283
-
<h2>Framing deviation</h2>
284
-
<p>Edge-to-edge field — the displaced sheet fills the frame and crops at the left, right, and bottom edges so the wave reads as a surface, not an object on a stage (measured fill 1.000x/0.817y with edge touch on three sides). If wired to <code>examples/gallery_framing.py</code>, call it with <code>deviation="edge-to-edge wave field; the fill is the point"</code>.</p>
283
+
<h2>Staging</h2>
284
+
<p>The still used to be an edge-to-edge field: the sheet cropped at the left, right and bottom edges on a black void, so nothing showed where the surface ended or what it stood on. <code>gallery_framing</code> has no <code>deviation=</code> flag any more, so that framing could not be gated at all.</p>
285
+
<p>The render path now stages a <strong>copy</strong> of the checked grid. Its boundary is extruded straight down to a flat base 0.30 m below the deepest trough, so the wave is the top face of a cast tile standing on the studio floor, framed whole. The checked <code>Wave</code> object is left exactly as asserted and hidden from the render. The copy is render-only and never enters <code>check()</code>. Measured framing on 5.2.1: fill 0.753 x / 0.761 y, every margin ≥ 0.117.</p>
285
286
<h2>Run</h2>
286
287
<pre><code># Cheap correctness check (no render) — the CI check:
<imgsrc="../assets/wave-displace-hero.webp" alt="A blue grid surface displaced into rolling sine-wave hills." />
529
+
<imgsrc="../assets/wave-displace-hero.webp" alt="A blue tile whose top is a grid displaced into rolling sine-wave hills, standing on a dark studio floor." />
Copy file name to clipboardExpand all lines: examples/gallery.json
+1-1Lines changed: 1 addition & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -60,7 +60,7 @@
60
60
"name": "wave-displace",
61
61
"dir": "examples/wave-displace",
62
62
"teaches": "Bulk vertex IO at real scale — 9,409 vertices displaced into a standing wave with one foreach_get and one foreach_set, no per-vertex access.",
63
-
"alt": "A blue grid surface displaced into rolling sine-wave hills.",
63
+
"alt": "A blue tile whose top is a grid displaced into rolling sine-wave hills, standing on a dark studio floor.",
64
64
"witnessesFix": "The bulk path is correct, not just fast: the Z span matches the wave amplitude and every vertex matches the closed-form wave, so a stride bug in the flat buffer cannot hide.",
0 commit comments