test: one forbidden-falsifier-exit set, and pin release-gate's content-smoke mirror

protocol.py forbade (0, 1, 77) while the catalog linter forbade {0, 1, 2, 77},
so a direct run_example.py --expect-exit 2 passed even though 2 is argparse
usage and a deleted flag exits 2 too. protocol.py now defines the set once,
including 2, and check_smoke_catalog and check_falsifier_targets import it;
the showcase static check also rejects a README falsifier declaring one.

release-gate.sh hand-copies content-smoke.yml's positive paths filter; a new
test fails when the two drift, so a direct push touching a newly filtered path
cannot release without waiting for Content Smoke.

Closes #537

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LpkeXRvikhJZSVGBFM91Dv
Signed-off-by: TM Hospitality Strategies <TMHospitalityStrategies@gmail.com>

Author: TMHSDigital

tests/check_falsifier_targets.py

@@ -53,6 +53,9 @@
 import time
 
 ROOT = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
+sys.path.insert(0, os.path.join(ROOT, "tests", "smoke"))
+from protocol import FORBIDDEN_FALSIFIER_EXITS  # noqa: E402
+
 SHOWCASE = os.path.join(ROOT, "showcase")
 
 # Pieces that predate the falsifier-table convention. Tracked for backfill;
@@ -209,6 +212,12 @@ def check_static():
                     (name, f"{flag} documented but not an argparse flag")
                 )
                 continue
+            if code in FORBIDDEN_FALSIFIER_EXITS:
+                failures.append(
+                    (name, f"{flag} declares exit {code}, which names no check "
+                           f"(forbidden: {sorted(FORBIDDEN_FALSIFIER_EXITS)})")
+                )
+                continue
             if code not in exits:
                 failures.append(
                     (name, f"{flag} declares exit {code}, absent from the "

tests/check_smoke_catalog.py

@@ -25,15 +25,17 @@
 import sys
 from pathlib import Path
 
+sys.path.insert(0, str(Path(__file__).resolve().parent / "smoke"))
+from protocol import FORBIDDEN_FALSIFIER_EXITS  # noqa: E402
+
 # Directories that intentionally have no smoke row. Keep empty unless justified.
 EXCLUDED: set[str] = set()
 
 ROW_KEYS = {"name", "script", "args", "min_version", "expect_file",
             "expect_sidecar", "sidecar_contains", "falsifiers", "timeout"}
 FALSIFIER_KEYS = {"args", "expect_exit", "expect_sidecar_fail", "min_version"}
-# 2 is argparse's usage-error exit: an unknown or deleted flag also exits 2,
-# so a falsifier expecting 2 passes even when its flag no longer exists.
-FORBIDDEN_EXITS = {0, 1, 2, 77}
+# Defined once in tests/smoke/protocol.py, which explains each code.
+FORBIDDEN_EXITS = set(FORBIDDEN_FALSIFIER_EXITS)
 
 
 def check_schema(row: dict) -> list[str]:

tests/smoke/protocol.py

@@ -59,9 +59,14 @@ def sidecar_ok(path: Optional[str], contains: Optional[str]) -> Tuple[bool, str]
     return True, ""
 
 
+# argparse exits 2 on a usage error, so an unknown or deleted flag also exits
+# 2: a falsifier expecting 2 passes even when its flag no longer exists.
+USAGE_EXIT = 2
+
 # Exits a falsifier may never "expect": 0 is a pass, 1 is the FATAL wrapper
-# (an uncaught exception, not a named check), 77 is a skip.
-FORBIDDEN_FALSIFIER_EXITS = (0, 1, SKIP_EXIT)
+# (an uncaught exception, not a named check), 2 is argparse usage, 77 is a
+# skip. The single source for every runner and linter (#537).
+FORBIDDEN_FALSIFIER_EXITS = (0, 1, USAGE_EXIT, SKIP_EXIT)
 
 
 def classify(

tests/smoke/test_harness.py

@@ -191,10 +191,17 @@ def test_other_check_is_fail(self):
     def test_crash_is_fail(self):
         self.assertEqual(self.c(1, expect_exit=7), FAIL)
 
-    def test_cannot_expect_0_1_or_77(self):
-        for bad in (0, 1, SKIP_EXIT):
+    def test_cannot_expect_0_1_2_or_77(self):
+        # 2 is argparse usage: a deleted flag exits 2 too (#537)
+        for bad in (0, 1, 2, SKIP_EXIT):
             self.assertEqual(self.c(bad, expect_exit=bad), FAIL)
 
+    def test_catalog_linter_shares_the_forbidden_set(self):
+        sys.path.insert(0, os.path.dirname(os.path.dirname(os.path.abspath(__file__))))
+        import check_smoke_catalog
+        from protocol import FORBIDDEN_FALSIFIER_EXITS
+        self.assertEqual(check_smoke_catalog.FORBIDDEN_EXITS, set(FORBIDDEN_FALSIFIER_EXITS))
+
     def test_legal_skip_stays_skip(self):
         out = "SMOKE_SKIP: needs 5.1\n"
         st, _ = classify(proc_exit=SKIP_EXIT, output=out, min_version="5.1",

tests/test_release_gate.py

@@ -129,6 +129,22 @@ def test_gate_mirrors_smoke_paths_ignore(self):
             self.assertIsNotNone(case, "release-gate.sh smoke-ignored case line not found")
             self.assertEqual(set(case.group(1).split("|")), want, event)
 
+    def test_gate_mirrors_content_smoke_paths(self):
+        # content_smoke_applies is release-gate.sh's copy of content-smoke.yml's
+        # positive `paths` filter; a path added to one must reach the other (#537).
+        import re
+        import yaml
+        wf = yaml.safe_load((REPO / ".github" / "workflows" / "content-smoke.yml")
+                            .read_text(encoding="utf-8"))
+        on = wf.get("on", wf.get(True))
+        body = GATE.read_text(encoding="utf-8").split("content_smoke_applies() {", 1)[1]
+        case = re.search(r"^\s*([^\n]*\|[^\n]*)\) return 0 ;;", body, re.M)
+        self.assertIsNotNone(case, "content_smoke_applies case line not found")
+        have = set(case.group(1).split("|"))
+        for event in ("push", "pull_request"):
+            want = {g.replace("/**", "/*") for g in on[event]["paths"]}
+            self.assertEqual(have, want, event)
+
     def test_truncated_file_list_waits_for_smoke(self):
         # 300 docs paths is the API's cap: a code change may sort after them.
         many = r"\n".join(f"docs/gallery/p{i:03d}.html" for i in range(300))