Skip to content

Commit d87acd3

Browse files
TMHSDigitalclaude
andcommitted
ci: keep smoke canaries out of the status file so zero PASS can turn red
canary-skip and canary-sidecar appended SKIP and PASS records to the same JSONL summarize.py reads for shipped examples, so every run carried at least one PASS and the documented 'zero PASS is red' guard could never fire. Both now run with --no-record, like the inverted canaries, and grep their own [SKIP]/[PASS] verdict. Closes #536 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LpkeXRvikhJZSVGBFM91Dv Signed-off-by: TM Hospitality Strategies <TMHospitalityStrategies@gmail.com>
1 parent 1cefaa0 commit d87acd3

1 file changed

Lines changed: 11 additions & 4 deletions

File tree

‎.github/workflows/blender-smoke.yml‎

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -325,16 +325,21 @@ jobs:
325325
--output "$RUNNER_TEMP/out/render.png" --engine CYCLES
326326
test -s "$RUNNER_TEMP/out/render.png" || { echo "::error::render PNG missing/empty"; exit 1; }
327327
328+
# Canaries never write to $BDT_SMOKE_STATUS: a canary PASS in the status
329+
# file would make summarize.py's "zero PASS is red" guard unreachable
330+
# (#536). Each one asserts its own verdict inline instead.
328331
- name: Canary - expected skip is SKIP not PASS
329332
run: |
330333
set -euo pipefail
331-
python3 tests/smoke/run_example.py \
334+
python3 tests/smoke/run_example.py --no-record \
332335
--name canary-skip \
333336
--blender "$BLENDER" \
334337
--script tests/smoke/canary_skip.py \
335338
--series "${{ matrix.series }}" \
336339
--min-version 99.0 \
337-
--xvfb
340+
--xvfb | tee "$RUNNER_TEMP/canary-skip.log"
341+
grep -q '^\[SKIP\] canary-skip:' "$RUNNER_TEMP/canary-skip.log" \
342+
|| { echo "::error::expected skip was not classified SKIP"; exit 1; }
338343
339344
- name: Canary - unexpected skip is red
340345
run: |
@@ -368,14 +373,16 @@ jobs:
368373
- name: Canary - post-exit sidecar
369374
run: |
370375
set -euo pipefail
371-
python3 tests/smoke/run_example.py \
376+
python3 tests/smoke/run_example.py --no-record \
372377
--name canary-sidecar \
373378
--blender "$BLENDER" \
374379
--script tests/smoke/canary_sidecar.py \
375380
--series "${{ matrix.series }}" \
376381
--expect-sidecar "$RUNNER_TEMP/out/canary.sidecar" \
377382
--sidecar-contains sidecar-ok \
378-
--xvfb
383+
--xvfb | tee "$RUNNER_TEMP/canary-sidecar.log"
384+
grep -q '^\[PASS\] canary-sidecar$' "$RUNNER_TEMP/canary-sidecar.log" \
385+
|| { echo "::error::post-exit sidecar canary did not PASS"; exit 1; }
379386
380387
- name: Canary - missing sidecar is red
381388
run: |

0 commit comments

Comments
 (0)