Skip to content

Commit f30667e

Browse files
TMHSDigitalclaude
andauthored
refactor(examples): drop 139 try/except guards that could never fire (#428)
129 example and showcase scripts wrapped `scene.eevee.taa_render_samples` and Principled v2 / Wave input names (Coat Weight, Specular IOR Level, Subsurface Weight, Detail Roughness) in `except AttributeError/KeyError/ Exception: pass`. Probed on 4.5.11 LTS, 5.1.2 and 5.2.1 LTS: every one of those attributes and sockets exists, so the guards were dead code that would silently swallow a typo in exactly the kind of name this repo exists to get right. The statements now run unguarded. Closes #405 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 5891799 commit f30667e

129 files changed

Lines changed: 139 additions & 552 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎examples/armature-bend/armature_bend.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -408,10 +408,7 @@ def light(name, loc, energy, size, col, rot):
408408
if engine == 'cycles':
409409
scene.cycles.samples = 32
410410
else:
411-
try:
412-
scene.eevee.taa_render_samples = 64
413-
except AttributeError:
414-
pass
411+
scene.eevee.taa_render_samples = 64
415412
scene.render.resolution_x = 1280
416413
scene.render.resolution_y = 720
417414
scene.render.image_settings.file_format = 'PNG'

‎examples/attribute-domain-shear/attribute_domain_shear.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -625,10 +625,7 @@ def render_still(path, engine):
625625
sc.cycles.samples = 64
626626
sc.cycles.use_denoising = True
627627
else:
628-
try:
629-
sc.eevee.taa_render_samples = 64
630-
except AttributeError:
631-
pass
628+
sc.eevee.taa_render_samples = 64
632629
sc.render.resolution_x = 1280
633630
sc.render.resolution_y = 720
634631
sc.render.image_settings.file_format = "PNG"

‎examples/bake-normal-high-to-low/bake_normal_high_to_low.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -572,10 +572,7 @@ def light(name, loc, energy, size, col, rot):
572572
scene.cycles.samples = 32
573573
scene.cycles.device = "CPU"
574574
else:
575-
try:
576-
scene.eevee.taa_render_samples = 64
577-
except AttributeError:
578-
pass
575+
scene.eevee.taa_render_samples = 64
579576
scene.render.resolution_x = 1280
580577
scene.render.resolution_y = 720
581578
scene.render.image_settings.file_format = "PNG"

‎examples/bmesh-gear/bmesh_gear.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -496,10 +496,7 @@ def light(name, loc, energy, size, col, aim):
496496
if engine == 'cycles':
497497
scene.cycles.samples = 48
498498
else:
499-
try:
500-
scene.eevee.taa_render_samples = 64
501-
except AttributeError:
502-
pass
499+
scene.eevee.taa_render_samples = 64
503500
scene.render.resolution_x = 1280
504501
scene.render.resolution_y = 720
505502
scene.render.image_settings.file_format = 'PNG'

‎examples/boolean-exact-volume/boolean_exact_volume.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -477,10 +477,7 @@ def light(name, loc, energy, size, col, aim):
477477
scene.cycles.samples = 64
478478
scene.cycles.transmission_bounces = 8
479479
else:
480-
try:
481-
scene.eevee.taa_render_samples = 64
482-
except AttributeError:
483-
pass
480+
scene.eevee.taa_render_samples = 64
484481
scene.render.resolution_x = 1280
485482
scene.render.resolution_y = 720
486483
scene.render.image_settings.file_format = 'PNG'

‎examples/car-mirror-symmetry/car_mirror_symmetry.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -838,10 +838,7 @@ def light(name, loc, energy, size, col, rot=None, at=None, size_y=None):
838838
if engine == 'cycles':
839839
scene.cycles.samples = 64
840840
else:
841-
try:
842-
scene.eevee.taa_render_samples = 64
843-
except AttributeError:
844-
pass
841+
scene.eevee.taa_render_samples = 64
845842
scene.render.resolution_x = 1280
846843
scene.render.resolution_y = 720
847844
scene.render.image_settings.file_format = 'PNG'

‎examples/collision-hull-proxy/collision_hull_proxy.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -477,10 +477,7 @@ def light(name, loc, energy, size, col, rot):
477477
if engine == 'cycles':
478478
scene.cycles.samples = 64
479479
else:
480-
try:
481-
scene.eevee.taa_render_samples = 64
482-
except AttributeError:
483-
pass
480+
scene.eevee.taa_render_samples = 64
484481
scene.render.resolution_x = 1280
485482
scene.render.resolution_y = 720
486483
scene.render.image_settings.file_format = 'PNG'

‎examples/color-attribute-wheel/color_attribute_wheel.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -405,10 +405,7 @@ def light(name, loc, energy, size, col, at):
405405
if engine == 'cycles':
406406
scene.cycles.samples = 64
407407
else:
408-
try:
409-
scene.eevee.taa_render_samples = 64
410-
except AttributeError:
411-
pass
408+
scene.eevee.taa_render_samples = 64
412409
scene.render.resolution_x = 1280
413410
scene.render.resolution_y = 720
414411
scene.render.image_settings.file_format = 'PNG'

‎examples/cross-version-property-delete/cross_version_property_delete.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -398,10 +398,7 @@ def light(name, loc, energy, size, col, rot):
398398
if engine == "cycles":
399399
scene.cycles.samples = 32
400400
else:
401-
try:
402-
scene.eevee.taa_render_samples = 64
403-
except AttributeError:
404-
pass
401+
scene.eevee.taa_render_samples = 64
405402
scene.render.resolution_x = 1280
406403
scene.render.resolution_y = 720
407404
scene.render.image_settings.file_format = "PNG"

‎examples/curve-bevel-arc/curve_bevel_arc.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -483,10 +483,7 @@ def light(name, loc, energy, size, col):
483483
if engine == 'cycles':
484484
scene.cycles.samples = 32
485485
else:
486-
try:
487-
scene.eevee.taa_render_samples = 64
488-
except AttributeError:
489-
pass
486+
scene.eevee.taa_render_samples = 64
490487
scene.render.resolution_x = 1280
491488
scene.render.resolution_y = 720
492489
scene.render.image_settings.file_format = 'PNG'

0 commit comments

Comments
 (0)