Skip to content

Commit e3426a1

Browse files
TMHSDigitalclaude
andcommitted
docs: record the second full review run in the ledger
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Wc67NX9MM964uaVGn4bpZJ
1 parent ff120aa commit e3426a1

1 file changed

Lines changed: 46 additions & 1 deletion

File tree

‎docs/review-ledger.md‎

Lines changed: 46 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,50 @@ Newest section at the top. One section per review run. This is the record of wha
44
run measured, what it changed, what it deliberately did not change, and what the next
55
run should not spend time re-deciding.
66

7+
## 2026-09-23 (second full run)
8+
9+
The fifteenth pass's next action: a fresh MODE=full run, measured from zero. Findings in
10+
`_scratch/reviews/2026-09-23-findings.md`; thresholds were written there before any
11+
script ran.
12+
13+
- Measured: 305 entries (275 active, 28 needs-review, 2 deprecated); commercial true 274,
14+
unknown 20, varies 9, false 2; 22 licence values, all in the vocabulary. Required fields
15+
305/305. `license_spdx` 239, `publisher` 135. Every `verified:` under 90 days (the 73
16+
July dates cross 90 on 2026-10-17). Every entry reaches `data.json` with no field
17+
dropped, and every entry has a listing row. Validator, build and tests exit 0.
18+
- **No licence defects found.** 26 "commercial but mentions non-commercial" keyword hits
19+
were read by hand; all were "commercial and non-commercial" phrasing.
20+
- Contrast measured on the live site in both schemes: 2,968 text nodes each, none below
21+
AA. Dialog focus trap, Escape and focus return pass. No horizontal scroll at 375px.
22+
- Executed, one commit each, in the order A, C, B, D so B's checks ran clean:
23+
- **A** (`a1b0ccb`): 4 `formats` case clashes (6 entries) and 4 `subcategories` pairs
24+
(4 entries) normalised; CONTRIBUTING now states a spelling convention for both
25+
fields, which had none; em dashes removed from 2 entry lines added by review passes
26+
and from the site tagline, hero and footer.
27+
- **C** (`e420bdc`): `godotsteam` custom to **MIT** and active, read on Codeberg in a
28+
browser; the Steamworks SDK is stated as Valve's separate agreement. `vroid-studio`
29+
attribution unknown to false, from Article 13 of pixiv's VRoid Studio terms.
30+
- **B** (`766e6b7`): **V13** rejects `formats`/`subcategories` values that differ only
31+
by case or punctuation; **V14** rejects `unknown` licence, commercial or attribution
32+
on an `active` entry. 51 assertions across 14 checks; both also proved by mutating
33+
real entries.
34+
- **D** (`ff120aa`): nav and entry title links 20px to 44px on touch screens, via inline
35+
padding, so the layout does not move.
36+
- **Correction to the audit:** it listed "active entries may lack Evidence" as a
37+
validator gap. `validate.mjs` already enforces that; only the `unknown` half was real.
38+
- **New defects found while executing, deferred by the no-scope-growth rule:**
39+
- **The sticky filter panel covers two thirds of a phone screen**: 527px of an 800px
40+
viewport, pinned while scrolling, leaving about 270px for entries. Desktop: 228px.
41+
- Five plural subcategory pairs (character/characters, environment/environments,
42+
interior/interiors, tileset/tilesets, vector/vectors). A convention call.
43+
- `formats` values that are not formats (`examples`, `many`, `runtime`, `windows`,
44+
`macOS`, `iOS`, `library`, `binary`).
45+
- Still needs the maintainer: `og:image` hosting, whether `data.json` (297 KB, unused by
46+
the page) is a public endpoint, the two `camera_perspective` scope questions.
47+
- Next highest-value action: **fix the sticky filter panel on phones.** It is the one
48+
finding that makes the live site worse to use for everyone on a phone, and the fix is
49+
contained: collapse the panel on small screens or stop it sticking there.
50+
751
## 2026-09-23 (fifteenth pass, same session)
852

953
The fourteenth pass's next action: clear the bot-blocked backlog with a real browser
@@ -42,7 +86,8 @@ The fourteenth pass's next action: clear the bot-blocked backlog with a real bro
4286
scope questions, `og:image` hosting, and whether `site/dist/data.json` is a public
4387
endpoint. Smaller: VRoid's credit terms, Musopen's ToS clause, Scan the World's
4488
per-object licences.
45-
- Next highest-value action: **a fresh MODE=full run of the review prompt.** Fifteen
89+
- Next highest-value action: ~~**a fresh MODE=full run of the review prompt.**~~ Done in
90+
the second full run above. Fifteen
4691
passes have run against measurements taken on 2026-09-22 at 294 entries. The catalog is
4792
now 305 entries with new checks, guides and a changed site; re-measuring from zero is
4893
how the next pass avoids optimising against stale numbers.

0 commit comments

Comments
 (0)