Skip to content

Commit f482137

Browse files
TMHSDigitalclaude
andauthored
Fix review issues #59-#74: exports, build robustness, link check, a11y, docs (#76)
- feed.xml: feed-level <author> (RFC 4287) (#59) - llms.mjs reads links with the shared LINK_RE, so balanced-paren hrefs cannot crash the build after the page gate (#60) - renderInline strips NUL before using it as a slot marker; validate rejects C0 control characters (#61) - catalog.csv neutralises formula-leading cells (#62) - shortlist button's accessible name starts with its visible text (#63) - one entry walker (lib/entry-files.mjs) for build, validate, sync-counts and check-links; kebab-case ids enforced (#64) - check-links: pure parts in lib/link-check.mjs with tests, multi-part suffixes, inert report URLs; V16 rejects private hosts (#65) - client lookups without a prototype; shortlist export slash fix (#66) - tests for all of the above (#67, partly) - "not legal advice" in README, licences guide, footers, CREDITS (#68) - ROADMAP without drifting counts or shipped items (#69) - contributor path aligned; TEMPLATE starts needs-review (#70) - README positioning vs magictools / awesome-gamedev, with credit (#71) - specs to docs/design, research-index out of user guides, trust-score labelled as a rubric (#73) - homepage WebSite + Dataset JSON-LD (#74) Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent 0b7d3c8 commit f482137

33 files changed

Lines changed: 327 additions & 103 deletions

‎.github/PULL_REQUEST_TEMPLATE.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,4 @@
1313
- [ ] Row added to the category `README.md`, with the same licence as the frontmatter
1414
- [ ] Ran `node site/sync-counts.mjs` after adding or removing entries
1515
- [ ] Stacks: followed `stacks/README.md`; no licence named in a stack's own words
16-
- [ ] `npm run check` passes (tests, `node site/validate.mjs`, `node site/build.mjs`)
16+
- [ ] `npm test && npm run validate` passes locally (CI runs the full `npm run check`, including the build)

‎CONTRIBUTING.md‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,18 @@ Please follow the [Code of Conduct](CODE_OF_CONDUCT.md).
1111
- Free engine add-ons / plugins that materially help asset or production pipelines (e.g. Godot Asset Library tools)
1212
- Engines only when they ship substantial free asset libraries
1313

14+
## Accepted with caveats
15+
16+
- A source whose licence is unclear: add it as `status: needs-review` with the open question in
17+
Notes, or open an issue instead.
18+
- A source that is free only for non-commercial or personal use: only if it is clearly marked
19+
`commercial: false`.
20+
1421
## What does not
1522

1623
- Paid-only marketplaces with no free content worth listing
17-
- Broken, abandoned, or license-unclear sources (use `status: needs-review` or open an issue)
24+
- Broken or abandoned sources
1825
- Redistributed ZIP/GLB/WAV files of third-party work
19-
- Assets that are free only for non-commercial / personal use (unless clearly tagged `commercial: false`)
2026
- GTA V / RDR2 extracts, FiveM MLO leaks, Tebex reuploads, and anonymous `fivem-props` dumps (see [`docs/fivem.md`](docs/fivem.md) and [`docs/high-risk.md`](docs/high-risk.md))
2127

2228
## Adding an entry
@@ -26,10 +32,10 @@ are no dependencies to install.
2632

2733
1. Run `node site/new-entry.mjs <category> <id>` (or `npm run new-entry -- <category> <id>`). It copies [`catalog/TEMPLATE.md`](catalog/TEMPLATE.md) to `catalog/<category>/<id>.md` with the id, category and today's date filled in, and refuses an id already used anywhere in the catalog. Use a short kebab-case `id`; a mixed kit already listed in another category is a duplicate, not a second entry.
2834
2. Verify the license on the live source page the day you submit, and fill every frontmatter field from it (rules below). Prefer primary URLs over mirror/aggregator pages.
29-
3. Write the body: a one-paragraph summary, `## Notes`, and `## Evidence` with a dated line quoting the source, such as `- Live page (2026-09-25): "Free for commercial use"`. Every Evidence section needs at least one date, and `verified` may not be newer than the newest one. The scaffold starts at `status: needs-review`; set `active` once the licence, the commercial stance and the credit requirement are all settled.
35+
3. Write the body: a one-paragraph summary, `## Notes`, `## Evidence` with a dated line quoting the source, such as `- Live page (2026-09-25): "Free for commercial use"`, and optionally `## Related` linking sibling entries. Every Evidence section needs at least one date, and `verified` may not be newer than the newest one. The template (and so the scaffold) starts at `status: needs-review`; set `active` once the licence, the commercial stance and the credit requirement are all settled.
3036
4. Add a row to the matching category `README.md`. This is required: the validator fails an entry that is not listed there, and the row's licence cell must match your frontmatter.
3137
5. Run `node site/sync-counts.mjs` (`npm run counts`). It updates every place the repo restates the entry count: both category count tables, the README badge and "Browse N sources" line, and `expectedEntryCount` in [`site/config.json`](site/config.json).
32-
6. Run `npm run check`: the check tests, `node site/validate.mjs` and `node site/build.mjs`, all of which must pass. The build renders your entry's page and fails if the body uses markdown the site does not support (tables, code fences, blockquotes, images, raw HTML, `###` headings, numbered lists) or links to a file that does not exist.
38+
6. Run `npm test && npm run validate` before you push; that is quick. CI then runs `npm run check` (the tests, `node site/validate.mjs` and `node site/build.mjs`), and all of it must pass. Run `npm run check` yourself if you changed the site or want to preview your entry's page. The build renders your entry's page and fails if the body uses markdown the site does not support (tables, code fences, blockquotes, images, raw HTML, `###` headings, numbered lists) or links to a file that does not exist.
3339
7. Optional: add the `id` to `site/config.json` → `featured` to pin it under Safe starting points.
3440

3541
To add a starter stack (one pick per need for a kind of game), follow [`stacks/README.md`](stacks/README.md).

‎README.md‎

Lines changed: 19 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,15 @@ Each entry records the licence as its source states it and the date someone read
2323
active entries quote the source's own words. The catalog indexes sources and never rehosts
2424
them: check the source before you ship.
2525

26+
Big lists such as [magictools](https://github.com/ellisonleao/magictools) and
27+
[awesome-gamedev](https://github.com/Calinou/awesome-gamedev) tell you something is free. This one
28+
tells you what the licence says, where it says it, and when it was last read, so you don't have to
29+
re-check forty tabs before a release. (Thanks to magictools: many tool entries started from its list.)
30+
31+
> [!NOTE]
32+
> This is the catalog's reading of each licence, not legal advice. Licences change: read the
33+
> source's own terms before you ship.
34+
2635
<table>
2736
<tr>
2837
<td width="33%" valign="top">
@@ -40,7 +49,8 @@ them: check the source before you ship.
4049
</tr>
4150
</table>
4251

43-
> **Recent:** 2026-09-30, 42 more sources, mostly pipeline, pixel-art and chiptune tools.
52+
> **Recent:** 2026-10-04, 15 more video, animation and environment sources.
53+
> 2026-09-30, 42 more sources, mostly pipeline, pixel-art and chiptune tools.
4454
> 2026-09-25, starter stacks and a licence freshness page.
4555
4656
## Contents
@@ -243,7 +253,7 @@ Read these before you mix packs into a commercial build.
243253
| [`docs/high-risk.md`](docs/high-risk.md) | Sources to avoid entirely |
244254
| [`docs/ai-assets.md`](docs/ai-assets.md) | AI-generated assets |
245255
| [`docs/fivem.md`](docs/fivem.md) | GTA-format and FiveM assets |
246-
| [`docs/trust-score.md`](docs/trust-score.md) | How sources are rated |
256+
| [`docs/trust-score.md`](docs/trust-score.md) | Review rubric used when vetting a source (not shown on entries) |
247257

248258
<details>
249259
<summary>The short version</summary>
@@ -304,9 +314,11 @@ When a source does not say plainly, the entry says `unknown` and `needs-review`
304314

305315
New sources, licence corrections, dead links and clearer notes are all welcome.
306316

307-
1. Start an entry with `npm run new-entry -- <category> <id>`, or copy [`catalog/TEMPLATE.md`](catalog/TEMPLATE.md).
317+
1. Start an entry with `npm run new-entry -- <category> <id>`. It copies the template, sets the
318+
id and date, and starts the entry as `needs-review`.
308319
2. Read the licence at the source and quote it, with the date, in the entry's Evidence section.
309-
3. Run `npm run check`, then open a pull request.
320+
3. Add a row for it to the category's `README.md`, then run `npm run counts` to update every count.
321+
4. Run `npm test && npm run validate` (quick), then open a pull request. CI also runs the full build.
310322

311323
[`CONTRIBUTING.md`](CONTRIBUTING.md) has the full checklist and how to verify a licence.
312324
Please follow the [Code of Conduct](CODE_OF_CONDUCT.md).
@@ -343,7 +355,9 @@ npm run serve # preview at http://localhost:3000
343355
├── docs/
344356
│ ├── licenses.md fonts.md geodata.md game-vs-video-licensing.md
345357
│ ├── provenance.md high-risk.md ai-assets.md fivem.md trust-score.md
346-
│ ├── godot-budget-stack.md research-index.md
358+
│ ├── godot-budget-stack.md
359+
│ ├── research-index.md maintainer notes on local research drafts
360+
│ ├── design/ design specs behind the entry pages, stacks and freshness page
347361
│ ├── review-ledger.md every review pass and what it changed
348362
│ └── images/readme/ publisher stills used in this README
349363
├── stacks/ starter stacks: one pick per need for a kind of game

‎ROADMAP.md‎

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,9 @@ missing entry, so freshness and accuracy come before volume.
55

66
## Open to contributors
77

8-
- **Thin categories:** video (8 entries), animation (12) and environment (13). See
9-
[CONTRIBUTING.md](CONTRIBUTING.md) and the "new source" issue form.
8+
- **Thin categories:** video, animation and environment are still the smallest (counts in the
9+
[category table](catalog/README.md)). See [CONTRIBUTING.md](CONTRIBUTING.md) and the "new
10+
source" issue form.
1011
- **Optional fields:** `camera_perspective` and `grid_dimensions` on 2D entries
1112
([#41](https://github.com/TMHSDigital/Free-Game-Dev-Assets/issues/41)). Small, well-scoped, a
1213
good first PR.
@@ -20,10 +21,14 @@ missing entry, so freshness and accuracy come before volume.
2021
- Re-verification in smaller, regular batches, so the July 2026 verifications do not all expire
2122
together in mid-2027.
2223
- A changelog page generated from [docs/review-ledger.md](docs/review-ledger.md).
23-
- Client-side search over the catalog, not only filters.
24-
- An accessibility pass over the site.
24+
- Full-text search over entry bodies (Notes and Evidence), not only names, tags and summaries.
2525

2626
## Done
2727

28+
- Site search across names, tags and summaries, with licence, format and category filters.
29+
- Accessibility fixes: focus handling, contrast, heading outline and tap targets (Lighthouse
30+
accessibility 100).
31+
- Thin categories topped up: 15 video, animation and environment sources (2026-10-04).
32+
2833
- Machine-readable exports: `data.json`, `catalog.csv` and an Atom feed (`feed.xml`) of recently
2934
verified entries.

‎catalog/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ One markdown file per source under a category folder. Copy [`TEMPLATE.md`](TEMPL
1515
| Animation | 17 | [`animation/`](animation/) | MoCap, character clips |
1616
| Video | 13 | [`video/`](video/) | Stock footage, archival clips |
1717

18-
Guides: [`docs/licenses.md`](../docs/licenses.md) · [`docs/provenance.md`](../docs/provenance.md) · [`docs/high-risk.md`](../docs/high-risk.md) · [`docs/fivem.md`](../docs/fivem.md) · [`docs/ai-assets.md`](../docs/ai-assets.md) · [`docs/trust-score.md`](../docs/trust-score.md) · [`docs/fonts.md`](../docs/fonts.md) · [`docs/geodata.md`](../docs/geodata.md) · [`docs/game-vs-video-licensing.md`](../docs/game-vs-video-licensing.md) · [`docs/godot-budget-stack.md`](../docs/godot-budget-stack.md) · [`docs/research-index.md`](../docs/research-index.md)
18+
Guides: [`docs/licenses.md`](../docs/licenses.md) · [`docs/provenance.md`](../docs/provenance.md) · [`docs/high-risk.md`](../docs/high-risk.md) · [`docs/fivem.md`](../docs/fivem.md) · [`docs/ai-assets.md`](../docs/ai-assets.md) · [`docs/trust-score.md`](../docs/trust-score.md) · [`docs/fonts.md`](../docs/fonts.md) · [`docs/geodata.md`](../docs/geodata.md) · [`docs/game-vs-video-licensing.md`](../docs/game-vs-video-licensing.md) · [`docs/godot-budget-stack.md`](../docs/godot-budget-stack.md)
1919

2020
**Which category.** File a source under the kind of content it mainly gives you.
2121
Software that exists to make one kind of content lives with that content, next to the

‎catalog/TEMPLATE.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ attribution_required: false
1212
formats: [glTF, FBX, PNG]
1313
# subcategories and formats spelling: see CONTRIBUTING.md (formats must be in site/format-vocabulary.json)
1414
tags: [low-poly, modular] # describe the content; never the licence or the publisher (V19, V21)
15-
verified: 2026-07-19
16-
status: active
15+
verified: 2026-07-19 # the day you read the licence at the source
16+
status: needs-review # set active once the licence is read and quoted in ## Evidence
1717
# Optional (omit if N/A):
1818
# publisher: Kenney # rights holder when that publisher has more than one entry; not a generic host
1919
# attribution_string: "Credit line" # required when attribution_required is true

‎catalog/tools/README.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -223,4 +223,4 @@ Software only. Not a GTA V asset grant. See [`docs/fivem.md`](../../docs/fivem.m
223223
| --- | --- | --- | --- |
224224
| [sollumz](sollumz.md) | Sollumz | GPL-3.0-or-later | active |
225225

226-
See: [`docs/godot-budget-stack.md`](../../docs/godot-budget-stack.md) · [`docs/ai-assets.md`](../../docs/ai-assets.md) · [`docs/fivem.md`](../../docs/fivem.md) · [`docs/research-index.md`](../../docs/research-index.md).
226+
See: [`docs/godot-budget-stack.md`](../../docs/godot-budget-stack.md) · [`docs/ai-assets.md`](../../docs/ai-assets.md) · [`docs/fivem.md`](../../docs/fivem.md).
File renamed without changes.
File renamed without changes.

docs/superpowers/specs/2026-09-25-licence-freshness-design.md renamed to docs/design/2026-09-25-licence-freshness-design.md

File renamed without changes.

0 commit comments

Comments
 (0)