[!!!][FEATURE] Support TYPO3 v13 and v14 in one version (#36)

* [TASK] Update repository metadata and TER publishing

The export-ignore list still named files this repository does not have,
while /Build and /Tests were missing from it, so both would have ended up
in a TER release. The eol list is sorted and gains the file types the
repository actually carries.

The publish workflow used the removed ::set-output syntax, which GitHub
Actions no longer evaluates, so the version and comment reached tailor
empty. It now writes to $GITHUB_OUTPUT, runs on ubuntu-latest with PHP
8.3, and checks out with the full history that "git tag -n10" needs to
read the tag annotation.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* [!!!][FEATURE] Support TYPO3 v13 and v14 in one version

The extension was last released as 10.0.4 in 2021. The v11 and v12 work on
develop was never tagged, and two unmerged branches carried an unfinished
migration to site sets. This brings all of it to one version that serves
TYPO3 13.4 LTS and TYPO3 14 together, on PHP 8.2 and up.

One version can serve both because the API this extension uses is the same
on either: the settings API, BeforeJavaScriptsRenderingEvent,
ResolveJavaScriptImportEvent and the AsEventListener attribute are
unchanged between 13.4 and 14.3, and both require PHP 8.2. The one real
difference is Fluid 4 against Fluid 5, which the ViewHelper handles by
registering its tag attributes as plain arguments, because
registerTagAttribute() was removed with Fluid 5.

The identifier argument of the script ViewHelper is now used as the
AssetCollector identifier. It was a required argument that had no effect,
so calling the ViewHelper twice with the same identifier now injects the
script once, which is what the argument always documented.

Defects fixed along the way:

* A site that does not include the site set answered HTTP 500 on every
  page, because an absent settingsId failed the identifier check and threw
  InvalidArgumentException 1583774571.
* An empty settingsId passed that same check and rendered a script tag
  with an empty ID instead of reporting the misconfiguration.
* Incomplete jsFiles and jsInline entries failed on an undefined array key
  instead of raising the documented exceptions.
* Usercentrics was rendered in backend requests.
* The useNonce argument was registered but never applied. It now maps to
  the AssetCollector option matching the running major, because v14
  deprecated useNonce in favour of csp.
* The settings type module was tagged "settings.type" in
  JavaScriptModules.php, a tag no core code reads. The import is
  registered through ResolveJavaScriptImportEvent instead, which is what
  makes the editor resolve it.
* composer.json declares extra.typo3/cms.version and an empty
  providesPackages. Without both, TYPO3 v14 still evaluates ext_emconf.php
  and raises a deprecation. The file stays, because the TER reads it.

Co-Authored-By: Marvin Buchmann <marvin.buchmann@typo3.com>
Co-Authored-By: Benjamin Franzke <ben@bnf.dev>
Co-Authored-By: Alexander Hahn <alexander@hahn.mg>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* [TASK] Add unit and functional test suites

The extension carried a single unit test class. What the event listener and
the ViewHelper actually put into the AssetCollector was never asserted, and
nothing proved that one code base renders the same on both majors.

57 unit tests cover the event listener, the ViewHelper, the file settings
type and the import map listener, including the defects this branch fixes.
9 functional tests render real frontend pages through the site set and
cover both documented ways of including a script; the regression test for
the untouched site fails against the previous state with
InvalidArgumentException 1583774571.

The suites are green on TYPO3 13.4.34 with Fluid 4.6.1, on 14.3.6 with
Fluid 5.3.1, and on the lowest dependency set. CI runs both majors on PHP
8.2, 8.3 and 8.4 plus a lowest run, and installs the TYPO3 version under
test with "composer update --with" instead of requiring it and checking
composer.json back out. Functional tests run on SQLite there, which is why
the workflow installs pdo_sqlite. CGL and lint move into a separate job, so
a formatting error does not hide a failing test matrix.

php-cs-fixer is configured in .php-cs-fixer.dist.php, the name the tool has
looked for since v3, and reports with --diff instead of -v.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* [TASK] Add a DDEV based development installation

Nothing in the repository brought the extension up in a browser. Reviewing
a rendering change meant building an installation by hand first.

.ddev/config.yaml declares the container only; the installation itself
stays out of the repository, which is why extra.typo3/cms.app-dir is
dropped and TYPO3 writes config/ below the Composer root, ignored like
var/. typo3/cms-install and typo3/cms-filelist are required for
development: the first provides the setup command the README documents,
the second the element browser the file settings type opens.

Build/usercentrics_demo is a development-only extension, wired in as a
path repository. Its site set provides the page TypoScript and a Fluid
template using the ViewHelper, so the rendering can be looked at. It is
never released, because Build/ is export-ignored.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* [DOCS] Rewrite documentation for the site set configuration

The manual described a static template the extension no longer ships, wrote
YAML examples in TypoScript syntax, documented the priority option at the
wrong level and carried a PHP example that could not run. It is corrected
and migrated from Settings.cfg to guides.xml, the format the rendering
toolchain reads.

The README now covers what the extension supports, how a site includes the
site set, both ways of registering a script, the migration from 12.x, and
how to bring the development installation up and run the test suites.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* [TASK] Clean up and add csp attribute

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-authored-by: Marvin Buchmann <marvin.buchmann@typo3.com>
Co-authored-by: Benjamin Franzke <ben@bnf.dev>
Co-authored-by: Alexander Hahn <alexander@hahn.mg>

Author: 5 people

.ddev/config.yaml

@@ -0,0 +1,23 @@
+name: ext-usercentrics
+type: typo3
+docroot: .build/public
+php_version: "8.3"
+webserver_type: apache-fpm
+xdebug_enabled: false
+additional_hostnames: []
+additional_fqdns: []
+database:
+    type: mariadb
+    version: "10.11"
+use_dns_when_possible: true
+composer_version: "2"
+web_environment:
+    - PATH=/var/www/html/.build/bin:$PATH
+    - TYPO3_CONTEXT=Development
+    # Read by the functional test suite. The account needs to create one database
+    # per test class, which is why it is root rather than the user the site runs as.
+    - typo3DatabaseDriver=mysqli
+    - typo3DatabaseHost=db
+    - typo3DatabaseName=t3func
+    - typo3DatabaseUsername=root
+    - typo3DatabasePassword=root

.gitattributes

@@ -1,39 +1,27 @@
-# Folders
-/.ddev export-ignore
+# Files and folders that are not part of a release
 /.github export-ignore
-/.vscode export-ignore
 /Build export-ignore
 /Tests export-ignore
+/.editorconfig export-ignore
+/.gitattributes export-ignore
+/.gitignore export-ignore
+/.php-cs-fixer.dist.php export-ignore
+/.phplint.yml export-ignore
 
-# Files
-.editorconfig export-ignore
-.gitattributes export-ignore
-.gitignore export-ignore
-.travis.yaml export-ignore
-.php_cs.dist
-.phplint.yml
-
-# Build
-package.json export-ignore
-webpack.config.js export-ignore
-yarn.lock export-ignore
-
-# Enforce checkout with linux lf consistent over all plattforms
-*.xml text eol=lf
-*.html text eol=lf
+# Enforce checkout with linux lf consistent over all platforms
 *.css text eol=lf
-*.tmpl text eol=lf
-*.less text eol=lf
+*.html text eol=lf
 *.js text eol=lf
 *.json text eol=lf
+*.md text eol=lf
 *.php text eol=lf
 *.rst text eol=lf
-*.md text eol=lf
-*.yml text eol=lf
-*.ts text eol=lf
-*.xlf text eol=lf
 *.sql text eol=lf
-*.t3s text eol=lf
+*.svg text eol=lf
+*.tsconfig text eol=lf
 *.txt text eol=lf
 *.typoscript text eol=lf
-*.tsconfig text eol=lf
+*.xlf text eol=lf
+*.xml text eol=lf
+*.yaml text eol=lf
+*.yml text eol=lf

.github/workflows/ci.yml

@@ -1,51 +1,81 @@
 name: CI
 
-on: [push]
+on:
+  push:
+  pull_request:
 
 jobs:
-  build:
+  cgl:
+    name: CGL and lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v5
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.2'
+          coverage: none
+
+      - name: Validate composer.json
+        run: composer validate --strict --no-check-lock
+
+      - name: Install dependencies
+        run: composer install --no-progress --ansi
 
+      - name: Install dev tools
+        run: |
+          for tool in `ls -1 Build/tools`; do
+            composer install --working-dir="Build/tools/$tool" --no-progress --ansi
+          done
+
+      - name: CGL
+        run: composer t3g:cgl
+
+      - name: Lint PHP
+        run: composer t3g:test:php:lint
+
+  tests:
+    name: TYPO3 ${{ matrix.typo3 }} on PHP ${{ matrix.php }} (${{ matrix.dependencies }})
     runs-on: ubuntu-latest
     strategy:
       fail-fast: false
       matrix:
-        typo3: [^13.4]
+        typo3: ['^13.4', '^14.3']
         php: ['8.2', '8.3', '8.4']
+        dependencies: ['highest']
         include:
-          - typo3: ^13.4
+          # Proves the lower bound the extension declares for TYPO3 v13.
+          - typo3: '^13.4'
             php: '8.2'
-          - typo3: ^13.4
-            php: '8.3'
-          - typo3: ^13.4
-            php: '8.4'
+            dependencies: 'lowest'
 
     steps:
-    - uses: actions/checkout@v3
-
-    - name: Setup PHP ${{ matrix.php }}
-      uses: shivammathur/setup-php@v2
-      with:
-        php-version: ${{ matrix.php }}
-
-    - name: Validate composer.json and composer.lock
-      run: composer validate
+      - uses: actions/checkout@v5
 
-    - name: Install dependencies
-      run: |
-        composer require typo3/cms-core:${{ matrix.typo3 }} --no-progress --ansi
-        git checkout composer.json
+      - name: Setup PHP ${{ matrix.php }}
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          extensions: pdo_sqlite, sqlite3
+          coverage: none
 
-    - name: Install dev tools
-      run: |
-        for tool in `ls -1 Build/tools`; do
-          composer install --working-dir="Build/tools/$tool" --no-progress --ansi
-        done
+      - name: Install dependencies
+        run: |
+          composer update \
+            --with "typo3/cms-core:${{ matrix.typo3 }}" \
+            ${{ matrix.dependencies == 'lowest' && '--prefer-lowest' || '' }} \
+            --no-progress --ansi
 
-    - name: CGL
-      run: composer t3g:cgl
+      # Informational only: "composer show" takes a single package, and a
+      # diagnostic step must not be able to fail the build.
+      - name: Show installed versions
+        run: composer show --locked
 
-    - name: Lint PHP
-      run: composer t3g:test:php:lint
+      - name: Unit Tests
+        run: composer t3g:test:php:unit
 
-    - name: Unit Tests
-      run: composer t3g:test:php:unit
+      - name: Functional Tests
+        env:
+          typo3DatabaseDriver: pdo_sqlite
+        run: composer t3g:test:php:functional

.github/workflows/publish.yml

@@ -1,4 +1,3 @@
-
 name: publish
 
 on:
@@ -10,41 +9,46 @@ jobs:
   publish:
     name: Publish new version to TER
     if: startsWith(github.ref, 'refs/tags/')
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-latest
     env:
       TYPO3_EXTENSION_KEY: ${{ secrets.TYPO3_EXTENSION_KEY }}
       TYPO3_API_TOKEN: ${{ secrets.TYPO3_API_TOKEN }}
 
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v2
+        uses: actions/checkout@v5
+        with:
+          fetch-depth: 0
 
       - name: Check tag
         run: |
-          if ! [[ ${{ github.ref }} =~ ^refs/tags/[0-9]{1,3}.[0-9]{1,3}.[0-9]{1,3}$ ]]; then
+          if ! [[ ${{ github.ref }} =~ ^refs/tags/[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}$ ]]; then
+            echo "Tag ${{ github.ref }} is not a valid TER version number."
             exit 1
           fi
+
       - name: Get version
         id: get-version
-        run: echo ::set-output name=version::${GITHUB_REF/refs\/tags\//}
+        run: echo "version=${GITHUB_REF#refs/tags/}" >> "$GITHUB_OUTPUT"
 
       - name: Get comment
         id: get-comment
         run: |
-          readonly local comment=$(git tag -n10 -l ${{ steps.get-version.outputs.version }} | sed "s/^[0-9.]*[ ]*//g")
+          comment=$(git tag -n10 -l "${{ steps.get-version.outputs.version }}" | sed "s/^[0-9.]*[ ]*//g")
           if [[ -z "${comment// }" ]]; then
-            echo ::set-output name=comment::Released version ${{ steps.get-version.outputs.version }} of ${{ env.TYPO3_EXTENSION_KEY }}
-          else
-            echo ::set-output name=comment::$comment
+            comment="Released version ${{ steps.get-version.outputs.version }} of ${TYPO3_EXTENSION_KEY}"
           fi
+          echo "comment=${comment}" >> "$GITHUB_OUTPUT"
+
       - name: Setup PHP
         uses: shivammathur/setup-php@v2
         with:
-          php-version: 8.0
+          php-version: '8.3'
           extensions: intl, mbstring, json, zip, curl
+          coverage: none
 
       - name: Install tailor
-        run: composer global require typo3/tailor --prefer-dist --no-progress --no-suggest
+        run: composer global require typo3/tailor --prefer-dist --no-progress
 
       - name: Publish to TER
-        run: php ~/.composer/vendor/bin/tailor ter:publish --comment "${{ steps.get-comment.outputs.comment }}" ${{ steps.get-version.outputs.version }}
+        run: php ~/.composer/vendor/bin/tailor ter:publish --comment "${{ steps.get-comment.outputs.comment }}" "${{ steps.get-version.outputs.version }}"

.gitignore

@@ -14,11 +14,13 @@ composer.lock
 .build/
 .ddev/**/*.example
 .ddev/**/*.txt
-.ddev/commands/
+Build/.phpunit.cache/
 Build/.phpunit.result.cache
 Documentation-GENERATED-temp/
 node_modules/
 var/
+
+# The installation TYPO3 writes below the Composer root
 config/
 
 # CGL Fixer

.php_cs-fixer.dist.php .php-cs-fixer.dist.php.php_cs-fixer.dist.php renamed to .php-cs-fixer.dist.php

@@ -1,19 +1,12 @@
 <?php
 
-/**
- * This file represents the configuration for Code Sniffing PSR-2-related
- * automatic checks of coding guidelines
- * Install @fabpot's great php-cs-fixer tool via
- *
- *  $ composer global require friendsofphp/php-cs-fixer
- *
- * And then simply run
- *
- *  $ php-cs-fixer fix
+declare(strict_types=1);
+
+/*
+ * This file is part of the package t3g/usercentrics.
  *
- * For more information read:
- *  http://www.php-fig.org/psr/psr-2/
- *  http://cs.sensiolabs.org
+ * For the full copyright and license information, please read the
+ * LICENSE file that was distributed with this source code.
  */
 
 if (PHP_SAPI !== 'cli') {
@@ -31,41 +24,39 @@
     ->setRiskyAllowed(true)
     ->setRules([
         '@PSR2' => true,
-        'header_comment' => [
-            'header' => $header
-        ],
-        'general_phpdoc_annotation_remove' => [
-            'annotations' => [
-                'author'
-            ],
-        ],
+        'array_syntax' => ['syntax' => 'short'],
+        'concat_space' => ['spacing' => 'one'],
+        'declare_equal_normalize' => ['space' => 'none'],
+        'general_phpdoc_annotation_remove' => ['annotations' => ['author']],
+        'header_comment' => ['header' => $header],
+        'lowercase_cast' => true,
+        'native_function_casing' => true,
+        'no_alias_functions' => true,
+        'no_blank_lines_after_phpdoc' => true,
+        'no_empty_statement' => true,
+        'no_extra_blank_lines' => true,
         'no_leading_import_slash' => true,
-        'no_trailing_comma_in_singleline' => true,
+        'no_leading_namespace_whitespace' => true,
+        'no_short_bool_cast' => true,
         'no_singleline_whitespace_before_semicolons' => true,
+        'no_trailing_comma_in_singleline' => true,
+        'no_unneeded_control_parentheses' => true,
         'no_unused_imports' => true,
-        'concat_space' => ['spacing' => 'one'],
         'no_whitespace_in_blank_line' => true,
         'ordered_imports' => true,
-        'single_quote' => true,
-        'no_empty_statement' => true,
-        'no_extra_blank_lines' => true,
         'phpdoc_no_package' => true,
         'phpdoc_scalar' => true,
-        'no_blank_lines_after_phpdoc' => true,
-        'array_syntax' => ['syntax' => 'short'],
-        'whitespace_after_comma_in_array' => true,
-        'function_typehint_space' => true,
-        'single_line_comment_style' => true,
-        'no_alias_functions' => true,
-        'lowercase_cast' => true,
-        'no_leading_namespace_whitespace' => true,
-        'native_function_casing' => true,
         'self_accessor' => true,
-        'no_short_bool_cast' => true,
-        'no_unneeded_control_parentheses' => true
+        'single_line_comment_style' => true,
+        'single_quote' => true,
+        'type_declaration_spaces' => true,
+        'whitespace_after_comma_in_array' => true,
     ])
     ->setFinder(
         PhpCsFixer\Finder::create()
             ->exclude('.build')
+            ->exclude('Build/tools')
+            ->exclude('config')
+            ->exclude('var')
             ->in(__DIR__)
     );

.phplint.yml

@@ -6,3 +6,5 @@ extensions:
 exclude:
     - .build
     - Build
+    - config
+    - var

Build/FunctionalTests.xml

@@ -0,0 +1,29 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit
+    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="../.build/vendor/phpunit/phpunit/phpunit.xsd"
+    backupGlobals="true"
+    bootstrap="../.build/vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTestsBootstrap.php"
+    cacheDirectory=".phpunit.cache"
+    cacheResult="false"
+    colors="true"
+    displayDetailsOnTestsThatTriggerDeprecations="true"
+    displayDetailsOnTestsThatTriggerErrors="true"
+    displayDetailsOnTestsThatTriggerNotices="true"
+    displayDetailsOnTestsThatTriggerWarnings="true"
+    failOnDeprecation="true"
+    failOnNotice="true"
+    failOnRisky="true"
+    failOnWarning="true"
+    requireCoverageMetadata="false"
+>
+    <testsuites>
+        <testsuite name="Usercentrics Extension">
+            <directory>../Tests/Functional/</directory>
+        </testsuite>
+    </testsuites>
+    <php>
+        <ini name="display_errors" value="1"/>
+        <env name="TYPO3_CONTEXT" value="Testing"/>
+    </php>
+</phpunit>