[TASK] Add GIT URI to Slack webhook - #313
Merged
Merged
Conversation
Currently only a composer key is emitted in the slack hook. However, a URI to the actua GIT repository would be helpful, because: 1.) A composer package may not have been released (yet) of an extension 2.) A TER package may not have been released (yet) of an extension 3.) The composer key and the Github Repo vendor/name may differ This commit is unverified. I am crossing my fingers that `$jar->getRepositoryUrl()` really holds what I expect it to. :-D
Contributor
|
The failing test is a fixture gap, not your change. $jar->setPackageName('acme/my-extension');
+ $jar->setRepositoryUrl('https://github.com/acme/my-extension.git');
$jar->setTypeShort('p');Plus an assertion, so the new link is covered: self::assertStringContainsString('<https://github.com/acme/my-extension.git|', $attachment['text']);Assisted by claude-code:claude-opus-5 — Session |
Contributor
Author
|
@CybotTM Thanks a lot! I implemented your suggestion, sounds sane to me. @andreaskienast Can you rerun the test? |
andreaskienast
approved these changes
Aug 25, 2026
andreaskienast
pushed a commit
that referenced
this pull request
Aug 25, 2026
The repository discovery message prints its footer link verbatim in
Slack: `TYPO3 Intercept ·
<{https://github.com/TYPO3GmbH/site-intercept/blob/develop/src/Service/SlackService.php}|(?)>`.
Cause:
[f055d02](f055d02)
moved the URL into `self::SOURCE_URL` and rewrote the footer as a
`sprintf()` format. The braces are PHP interpolation syntax: they
disappear in the previous `"TYPO3 Intercept · <{$sourceUrl}|(?)>"`, but
stay literal in a format string, and Slack parses `<url|label>` only
with a bare URL. The footer link rendered fine before that commit.
Fix: drop the braces from the format string. `(?)` is a link again.
Tests: the two existing footer assertions match substrings
(`github.com/TYPO3GmbH/site-intercept`, `SlackService.php`) and pass on
the broken markup, which is why this went unnoticed. The test now also
requires every `<url|label>` target in `text` and in `footer` to be a
bare absolute URL. Verified by reverting the fix — the new assertion
fails on `{https://…}` and passes with it.
Note on local verification: the functional suite boots the test kernel,
which needs the private `t3g/lib-test-helper`, so I ran the assertions
locally against a directly instantiated `SlackService` with test
doubles. CI runs the committed test.
Unrelated to #313, which adds a repository link to the message text —
that PR fails on a separate fixture gap
(`DocumentationJar::$repositoryUrl` is never set in the test).
_Assisted by claude-code:claude-opus-5 —
[Session](https://claude.ai/code/session_014H1xwaAmrQRWUA3vx8bJcD)_
Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
andreaskienast
pushed a commit
that referenced
this pull request
Aug 25, 2026
Currently only a composer key is emitted in the slack hook. However, a URI to the actua GIT repository would be helpful, because: 1.) A composer package may not have been released (yet) of an extension 2.) A TER package may not have been released (yet) of an extension 3.) The composer key and the Github Repo vendor/name may differ This commit is unverified. I am crossing my fingers that `$jar->getRepositoryUrl()` really holds what I expect it to. :-D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently only a composer key is emitted in the slack hook. However, a URI to the actua GIT repository would be helpful, because:
1.) A composer package may not have been released (yet) of an extension 2.) A TER package may not have been released (yet) of an extension 3.) The composer key and the Github Repo vendor/name may differ
This commit is unverified. I am crossing my fingers that
$jar->getRepositoryUrl()really holds what I expect it to. :-D