[BUGFIX] Remove interpolation braces from Slack footer link - #314
Merged
Conversation
CybotTM
marked this pull request as ready for review
August 24, 2026 11:55
f055d02 moved the source URL into a constant and turned the footer into a sprintf() format. The braces around the placeholder are PHP interpolation syntax and only vanish inside a double quoted string, so Slack now receives `<{https://…/SlackService.php}|(?)>` and prints that verbatim instead of the "(?)" link. The existing footer assertions match substrings and pass on the broken markup, so the test additionally requires every link target in the text and in the footer to be a bare URL. Assisted-by: claude-code:claude-opus-5 Agent-Session: https://claude.ai/code/session_014H1xwaAmrQRWUA3vx8bJcD Agent-Host: 0493f0 Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
andreaskienast
force-pushed
the
fix/slack-footer-link
branch
from
August 25, 2026 05:16
6d7df60 to
39d035e
Compare
andreaskienast
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The repository discovery message prints its footer link verbatim in Slack:
TYPO3 Intercept · <{https://github.com/TYPO3GmbH/site-intercept/blob/develop/src/Service/SlackService.php}|(?)>.Cause: f055d02 moved the URL into
self::SOURCE_URLand rewrote the footer as asprintf()format. The braces are PHP interpolation syntax: they disappear in the previous"TYPO3 Intercept · <{$sourceUrl}|(?)>", but stay literal in a format string, and Slack parses<url|label>only with a bare URL. The footer link rendered fine before that commit.Fix: drop the braces from the format string.
(?)is a link again.Tests: the two existing footer assertions match substrings (
github.com/TYPO3GmbH/site-intercept,SlackService.php) and pass on the broken markup, which is why this went unnoticed. The test now also requires every<url|label>target intextand infooterto be a bare absolute URL. Verified by reverting the fix — the new assertion fails on{https://…}and passes with it.Note on local verification: the functional suite boots the test kernel, which needs the private
t3g/lib-test-helper, so I ran the assertions locally against a directly instantiatedSlackServicewith test doubles. CI runs the committed test.Unrelated to #313, which adds a repository link to the message text — that PR fails on a separate fixture gap (
DocumentationJar::$repositoryUrlis never set in the test).Assisted by claude-code:claude-opus-5 — Session