Implement feedback collection preferences for elimination rounds - #2903
Open
TrudeauOkech wants to merge 4 commits into
Open
Implement feedback collection preferences for elimination rounds#2903TrudeauOkech wants to merge 4 commits into
TrudeauOkech wants to merge 4 commits into
Conversation
tienne-B
reviewed
Aug 2, 2026
Member
There was a problem hiding this comment.
I'd think the feedback expectations would remain the same between rounds; why are we copying the feedback paths and not a pref like "Expect team feedback for these rounds" with options for prelim only or prelims + elims ?
How should this work for silent rounds?
Contributor
Author
There was a problem hiding this comment.
I've dropped feedback paths and replaced with two scope preferences (Expect feedback from adjudicators in and Expect feedback from teams in, each prelims only / prelims + elims, defaulting to prelims only).
For silent rounds, matching prelims today (teams are never expected to give feedback in a silent round in either stage, while adjudicators still are).
What do you think? Does this work better?
Resets the elimination feedback work; it is reimplemented on top as a round-scope preference per review on TabbycatDebate#2903.
Replaces the duplicated elimination-round feedback path preferences with two scope preferences that control which rounds feedback is expected in. The feedback paths and team feedback options keep their existing meaning across both stages.
Covers the feedback form choices, the bulk get_feedback_progress path, and stage-dependent orallist enforcement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2655