fix(plugins)!: SQL Server tables on connect, cell-edit datetime, chip parity; PluginKit ABI 10→11 (#1183)

* fix(plugins)!: SQL Server tables on connect, cell-edit datetime, chip parity; PluginKit ABI 10→11

* wip

* fix(plugin-mssql): tighten datetime parser; revert xcstrings drift; add test coverage; oracle switchDatabase override

* fix(plugin-mssql): skip IDENTITY columns from INSERT

Author: datlechin

CHANGELOG.md

@@ -74,6 +74,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Fixed
 
+- Tables in the sidebar now load automatically after a slow connect. SQL Server connections previously showed "No Tables" until the user manually picked a schema; the same race could affect other engines on slow networks. The post-connect listener now triggers the schema load once the driver is bound.
+- SQL Server `switchDatabase` now actually switches the database (`USE <database>`) instead of being routed through a schema switch. Switching from a saved tab pointing at a different database used to overwrite the current schema with the database name and leave the table list empty until the user manually re-picked a schema.
+- SQL Server cell edits now save without "Conversion failed when converting date and/or time from character string." Tables with primary keys use a PK-only WHERE clause (no longer including every column), and DATETIME / DATETIME2 / SMALLDATETIME values round-trip as ISO 8601 instead of FreeTDS's `MMM d yyyy h:mm:ss:fffAM` format that SQL Server's parser rejects.
+- SQL Server INSERTs skip IDENTITY columns automatically. Adding a new row no longer fails with "Cannot insert explicit value for identity column ... when IDENTITY_INSERT is set to OFF". The server allocates the value and TablePro omits the column from the INSERT.
+- Toolbar database/schema chip reflects the correct unit from the moment a connection is established. SQL Server, PostgreSQL, Oracle, and BigQuery connections show the active schema; MySQL, SQLite, Redis, and other database-grouped engines show the active database.
+- SQL Server connections use the server-reported default schema (`SELECT SCHEMA_NAME()`) rather than a hardcoded `dbo`, so users with a non-default schema in `sys.database_principals` see their tables on connect. The connection form's Schema field still acts as an explicit override.
 - Holding Cmd+Return at safe-mode level `.silent` no longer stacks two confirmation sheets and runs the dangerous query twice. The `.silent` branch in `QueryExecutionCoordinator.dispatchStatements` and `dispatchParameterizedStatements` now sets the same `isShowingSafeModePrompt` re-entry flag synchronously that the `requiresConfirmation` branch already used; the flag is cleared in a `defer` inside the spawned `Task`.
 - LSP `cancelRequest` no longer leaks a pending continuation when the underlying transport is mid-shutdown. The previous `try? writeMessage(data)` swallowed the failure, leaving the local handler stuck waiting for a response the LSP server would never produce. The new path logs the failure and resolves the pending entry with `CancellationError`, so AI inline-suggestion / Copilot LSP teardown no longer leaks completion handlers across the lifetime of the LSP process.
 - Plugin auto-update no longer drops new rejection entries that arrive from concurrent operations (e.g., a manual install failure during the auto-update loop). `PluginManager.autoUpdateRejectedPlugins` previously snapshotted `rejectedPlugins` at entry, looped through awaits that could mutate it, then assigned the stale snapshot back at the end. The fix replaces only the entries it processed and preserves any concurrent additions.

Plugins/BigQueryDriverPlugin/BigQueryPluginDriver.swift

@@ -531,6 +531,7 @@ internal final class BigQueryPluginDriver: PluginDatabaseDriver, @unchecked Send
     func generateStatements(
         table: String,
         columns: [String],
+        primaryKeyColumns: [String],
         changes: [PluginRowChange],
         insertedRowData: [Int: [String?]],
         deletedRowIndices: Set<Int>,

Plugins/BigQueryDriverPlugin/Info.plist

@@ -3,6 +3,6 @@
 <plist version="1.0">
 <dict>
 	<key>TableProPluginKitVersion</key>
-	<integer>10</integer>
+	<integer>11</integer>
 </dict>
 </plist>

Plugins/CSVExportPlugin/Info.plist

@@ -3,7 +3,7 @@
 <plist version="1.0">
 <dict>
 	<key>TableProPluginKitVersion</key>
-	<integer>10</integer>
+	<integer>11</integer>
 	<key>TableProProvidesExportFormatIds</key>
 	<array>
 		<string>csv</string>

Plugins/CassandraDriverPlugin/Info.plist

@@ -21,6 +21,6 @@
 	<key>NSPrincipalClass</key>
 	<string>$(PRODUCT_MODULE_NAME).CassandraPlugin</string>
 	<key>TableProPluginKitVersion</key>
-	<integer>10</integer>
+	<integer>11</integer>
 </dict>
 </plist>

Plugins/ClickHouseDriverPlugin/ClickHousePlugin.swift

@@ -601,6 +601,7 @@ final class ClickHousePluginDriver: PluginDatabaseDriver, @unchecked Sendable {
     func generateStatements(
         table: String,
         columns: [String],
+        primaryKeyColumns: [String],
         changes: [PluginRowChange],
         insertedRowData: [Int: [String?]],
         deletedRowIndices: Set<Int>,

Plugins/ClickHouseDriverPlugin/Info.plist

@@ -3,7 +3,7 @@
 <plist version="1.0">
 <dict>
 	<key>TableProPluginKitVersion</key>
-	<integer>10</integer>
+	<integer>11</integer>
 	<key>TableProProvidesDatabaseTypeIds</key>
 	<array>
 		<string>ClickHouse</string>

Plugins/CloudflareD1DriverPlugin/Info.plist

@@ -3,6 +3,6 @@
 <plist version="1.0">
 <dict>
 	<key>TableProPluginKitVersion</key>
-	<integer>10</integer>
+	<integer>11</integer>
 </dict>
 </plist>

Plugins/DuckDBDriverPlugin/Info.plist

@@ -3,6 +3,6 @@
 <plist version="1.0">
 <dict>
 	<key>TableProPluginKitVersion</key>
-	<integer>10</integer>
+	<integer>11</integer>
 </dict>
 </plist>

Plugins/DynamoDBDriverPlugin/DynamoDBPluginDriver.swift

@@ -484,6 +484,7 @@ internal final class DynamoDBPluginDriver: PluginDatabaseDriver, @unchecked Send
     func generateStatements(
         table: String,
         columns: [String],
+        primaryKeyColumns: [String],
         changes: [PluginRowChange],
         insertedRowData: [Int: [String?]],
         deletedRowIndices: Set<Int>,