Repository navigation
refactor/fix/perf(ui): MVC split ItemThumb + ThumbGrid, fixes and performance - #1539
Merged
Merged
Conversation
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is targeting the
devbranch for release with Alpha v9.7.Summary
This PR includes MVC refactors for
ItemThumbandThumbGridplus several fixes and performance improvements for the thumbnail grid system. Several bugs with theBrowsingStateforThumbGridhave been fixed, notably the re-implementation of saving paginated pages in the history and fixing several issues with the scrollbar position not behaving correctly in history states. This was also an opportunity to make it so resizing the thumbnail sizes no longer triggers a full refresh and works much more smoothly (still room for improvement though).The individual commits on here show where each refactor and fix was added.
MVC Structure
ItemThumb+ThumbButton->ItemThumb/ItemThumbViewThumbGridLayout->ThumbGrid/ThumbGridLayout(not aThumbGridViewbecause it's a generic layout)EntryState+ Badge SyncingTag badges on
ItemThumbs are now centrally managed byEntryState, which is where all entries' tag writes route from the frontend to the backend now. This acts as part of a foundation mentioned in this comment in order to finally implement #337/#808 soundly in the near future.Other Notes
pydubas a dependency, including the vendored file.ItemThumbbadge icons now being moved to theResourceManager.Tasks Completed