fix(examples/svelte/{basic,ssr}): remove the '!postId' check that kept 'Loading...' next to the error for non-numeric post ids by sukvvon · Pull Request #12119 · TanStack/query

sukvvon · 2026-10-19T01:04:13Z

🎯 Changes

In examples/svelte/basic and examples/svelte/ssr, Post.svelte showed Loading... when !postId || post.isPending. postId comes from parseInt(params.postId), so a non-numeric or 0 id made !postId true and Loading... stayed next to Error: ... after the query failed.

Show Loading... only while post.isPending.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Bug Fixes
- Loading indicators now appear only while a post is pending, rather than when its ID is falsy.

…t 'Loading...' next to the error for non-numeric post ids

changeset-bot · 2026-10-19T01:04:20Z

⚠️ No Changeset found

Latest commit: 3cb4b12

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-19T01:04:42Z

View your CI Pipeline Execution ↗ for commit 3cb4b12

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 13s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	<1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-19 01:08:31 UTC

github-actions · 2026-10-19T01:05:06Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-10-19T01:06:26Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12119

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12119

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12119

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12119

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12119

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12119

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12119

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12119

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12119

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12119

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12119

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12119

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12119

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12119

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12119

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12119

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12119

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12119

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12119

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12119

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12119

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12119

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12119

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12119

commit: 3cb4b12

github-actions · 2026-10-19T01:06:34Z

size-limit report 📦

Path	Size
react full	11.74 KB (0%)
react minimal	8.6 KB (0%)

coderabbitai · 2026-10-19T01:06:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: eb736daf-0566-4566-b458-739bfe2e2830

📥 Commits

Reviewing files that changed from the base of the PR and between adb932e and 3cb4b12.

📒 Files selected for processing: 2

examples/svelte/basic/src/lib/Post.svelte
examples/svelte/ssr/src/lib/Post.svelte

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Both Svelte Post examples now render their loading indicator only when post.isPending. A falsy postId no longer triggers the indicator.

Changes: Svelte loading conditions

Layer / File(s)	Summary
Use pending state for loading `examples/svelte/basic/src/lib/Post.svelte`, `examples/svelte/ssr/src/lib/Post.svelte`	Both examples now show the loading indicator only while `post.isPending`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to 3cb4b

The loading indicator now follows query status in both examples. No concrete issue remains that should prevent merging.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the Svelte examples affected and the removal of the incorrect '!postId' loading condition.
Description check		The description explains the bug, the motivation, the exact change, test status, AI policy status, and release impact. All required template sections are present.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

fix(examples/svelte/{basic,ssr}): remove the '!postId' check that kep…

3cb4b12

…t 'Loading...' next to the error for non-numeric post ids

sukvvon self-assigned this Oct 19, 2026

sukvvon merged commit 9423149 into main Oct 19, 2026
9 checks passed

sukvvon deleted the fix/svelte-post-loading-with-invalid-id branch October 19, 2026 01:15

Navigation Menu

Repository navigation

fix(examples/svelte/{basic,ssr}): remove the '!postId' check that kept 'Loading...' next to the error for non-numeric post ids - #12119

fix(examples/svelte/{basic,ssr}): remove the '!postId' check that kept 'Loading...' next to the error for non-numeric post ids#12119
sukvvon merged 1 commit into
mainfrom
fix/svelte-post-loading-with-invalid-id

sukvvon commented Oct 19, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 19, 2026

Uh oh!

nx-cloud Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

pkg-pr-new Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

Uh oh!

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 19, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 19, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 19, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Oct 19, 2026

Uh oh!

github-actions Bot commented Oct 19, 2026

size-limit report 📦

Uh oh!

coderabbitai Bot commented Oct 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 19, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 19, 2026 •

edited

Loading

coderabbitai Bot commented Oct 19, 2026 •

edited

Loading