Skip to content

refactor(query-persist-client-core/createPersister): rename the 'filters' option to 'persistFilters' internally to avoid shadowing #12290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sukvvon merged 1 commit into from
Oct 23, 2026
Merged

refactor(query-persist-client-core/createPersister): rename the 'filters' option to 'persistFilters' internally to avoid shadowing #12290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/query-persist-client-core/src/createPersister.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ export function experimental_createQueryPersister<TStorageValue = string>({
>['deserialize'],
prefix = PERSISTER_KEY_PREFIX,
refetchOnRestore = true,
filters,
filters: persistFilters,
}: StoragePersisterOptions<TStorageValue>) {
/**
* Checks whether a persisted query should be discarded.
Expand Down Expand Up @@ -280,7 +280,9 @@ export function experimental_createQueryPersister<TStorageValue = string>({
ctx: QueryFunctionContext<TQueryKey>,
query: Query,
) {
const matchesFilter = filters ? matchQuery(filters, query) : true
const matchesFilter = persistFilters
? matchQuery(persistFilters, query)
: true

// Try to restore only if we do not have any data in the cache and we have persister defined
if (matchesFilter && query.state.data === undefined && storage != null) {
Expand Down
Loading