test(*/useMutationState): rename the built 'mutation' to 'existingMutation' to avoid shadowing the 'select' parameter by sukvvon · Pull Request #12294 · TanStack/query

sukvvon · 2026-10-23T06:47:00Z

🎯 Changes

In the useMutationState tests of lit-query, react-query, and preact-query, the mutation created with cache.build(...) was named mutation, which is shadowed by the select callback's mutation parameter (no-shadow).

Rename the outer variable to existingMutation, keeping mutation for the select parameter.
Apply the same change to preact-query, which has the same test code as react-query.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated mutation-state test coverage across Lit, Preact, and React. Tests verify that selector results reflect changed mutation metadata while mutation state remains unchanged, and preserve checks for cache notification behavior.

…ation' to avoid shadowing the 'select' parameter

changeset-bot · 2026-10-23T06:47:06Z

⚠️ No Changeset found

Latest commit: b551851

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-23T06:47:27Z

View your CI Pipeline Execution ↗ for commit b551851

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 9s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	9s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 06:51:28 UTC

github-actions · 2026-10-23T06:47:57Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-23T06:48:34Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: test/use-mutation-state-rename-existing-mutation
File: .coderabbit.yaml
Commit: b551851
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: 5bd23be1-2e53-414f-b120-b66dca3d7d05

📥 Commits

Reviewing files that changed from the base of the PR and between d09972b and b551851.

📒 Files selected for processing: 3

packages/lit-query/src/__tests__/useMutationState.test.ts
packages/preact-query/src/__tests__/useMutationState.test.tsx
packages/react-query/src/__tests__/useMutationState.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Mutation state tests in Lit, Preact, and React now use a named reference to the mutation created during setup. The tests retain their existing selected-state checks and verify state identity where applicable.

Changes: Mutation state tests

Layer / File(s)	Summary
Use the existing mutation reference `packages/lit-query/src/__tests__/useMutationState.test.ts`, `packages/preact-query/src/__tests__/useMutationState.test.tsx`, `packages/react-query/src/__tests__/useMutationState.test.tsx`	The tests use `existingMutation` for cache notification, option updates, and state identity checks.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: tkdodo, chughgaurav

Merge Risk: ⚪ Minimal · up to b5518

No production behavior changes or actionable merge-blocking risks were identified.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly identifies the test files, the variable rename, and the reason for the change: avoiding shadowing of the select parameter.
Description check		The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, lists the affected packages, records the test and policy checks, and identifies the c…
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, lists the affected packages, records the test and policy checks, and identifies the change as dev-only.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3 files.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-23T06:49:11Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12294

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12294

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12294

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12294

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12294

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12294

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12294

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12294

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12294

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12294

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12294

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12294

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12294

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12294

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12294

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12294

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12294

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12294

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12294

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12294

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12294

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12294

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12294

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12294

commit: b551851

github-actions · 2026-10-23T06:49:27Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

test(*/useMutationState): rename the built 'mutation' to 'existingMut…

b551851

…ation' to avoid shadowing the 'select' parameter

sukvvon self-assigned this Oct 23, 2026

sukvvon merged commit 86b9f20 into main Oct 23, 2026
9 checks passed

sukvvon deleted the test/use-mutation-state-rename-existing-mutation branch October 23, 2026 06:52

coderabbitai Bot mentioned this pull request Oct 25, 2026

test(preact-query/useMutation): wait for the mutation to settle after unmount and assert that no error is logged #12335

Merged

4 of 5 tasks

Navigation Menu

Repository navigation

test(*/useMutationState): rename the built 'mutation' to 'existingMutation' to avoid shadowing the 'select' parameter - #12294

test(*/useMutationState): rename the built 'mutation' to 'existingMutation' to avoid shadowing the 'select' parameter#12294
sukvvon merged 1 commit into
mainfrom
test/use-mutation-state-rename-existing-mutation

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026

Uh oh!

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 23, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading