From b5518514f213859f37fa3de8b3b93e6b8f641677 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Fri, 23 Oct 2026 15:46:49 +0900 Subject: [PATCH] test(*/useMutationState): rename the built 'mutation' to 'existingMutation' to avoid shadowing the 'select' parameter --- .../lit-query/src/__tests__/useMutationState.test.ts | 4 ++-- .../src/__tests__/useMutationState.test.tsx | 11 +++++++---- .../src/__tests__/useMutationState.test.tsx | 11 +++++++---- 3 files changed, 16 insertions(+), 10 deletions(-) diff --git a/packages/lit-query/src/__tests__/useMutationState.test.ts b/packages/lit-query/src/__tests__/useMutationState.test.ts index 6b9f4a12bbc..20fe5819bf5 100644 --- a/packages/lit-query/src/__tests__/useMutationState.test.ts +++ b/packages/lit-query/src/__tests__/useMutationState.test.ts @@ -88,7 +88,7 @@ describe('useMutationState', () => { it('should not request another update when mutation cache emits with unchanged selected state', async () => { const mutationKey = createKey() - const mutation = queryClient.getMutationCache().build(queryClient, { + const existingMutation = queryClient.getMutationCache().build(queryClient, { mutationKey, }) @@ -127,7 +127,7 @@ describe('useMutationState', () => { for (let i = 0; i < 5; i += 1) { queryClient.getMutationCache().notify({ type: 'updated', - mutation, + mutation: existingMutation, action: { type: 'pause' } as never, }) await vi.advanceTimersByTimeAsync(0) diff --git a/packages/preact-query/src/__tests__/useMutationState.test.tsx b/packages/preact-query/src/__tests__/useMutationState.test.tsx index 87d7a804b31..8b7637112d8 100644 --- a/packages/preact-query/src/__tests__/useMutationState.test.tsx +++ b/packages/preact-query/src/__tests__/useMutationState.test.tsx @@ -308,11 +308,11 @@ describe('useMutationState', () => { const queryClient = new QueryClient() const key = createKey() const cache = queryClient.getMutationCache() - const mutation = cache.build(queryClient, { + const existingMutation = cache.build(queryClient, { mutationKey: key, meta: { time: 0 }, }) - const state = mutation.state + const state = existingMutation.state const filters = { mutationKey: key } const select = (mutation: Mutation) => resultType === 'Date' @@ -336,7 +336,10 @@ describe('useMutationState', () => { ), ).toBeInTheDocument() - mutation.setOptions({ ...mutation.options, meta: { time: 1000 } }) + existingMutation.setOptions({ + ...existingMutation.options, + meta: { time: 1000 }, + }) rendered.rerender() expect( rendered.getByText( @@ -345,7 +348,7 @@ describe('useMutationState', () => { : 'result: [{"time":1000}]', ), ).toBeInTheDocument() - expect(mutation.state).toBe(state) + expect(existingMutation.state).toBe(state) expect(onCacheChange).not.toHaveBeenCalled() unsubscribe() }, diff --git a/packages/react-query/src/__tests__/useMutationState.test.tsx b/packages/react-query/src/__tests__/useMutationState.test.tsx index 1ced91010cb..a0eecb1074c 100644 --- a/packages/react-query/src/__tests__/useMutationState.test.tsx +++ b/packages/react-query/src/__tests__/useMutationState.test.tsx @@ -308,11 +308,11 @@ describe('useMutationState', () => { const queryClient = new QueryClient() const key = createKey() const cache = queryClient.getMutationCache() - const mutation = cache.build(queryClient, { + const existingMutation = cache.build(queryClient, { mutationKey: key, meta: { time: 0 }, }) - const state = mutation.state + const state = existingMutation.state const filters = { mutationKey: key } const select = (mutation: Mutation) => resultType === 'Date' @@ -336,7 +336,10 @@ describe('useMutationState', () => { ), ).toBeInTheDocument() - mutation.setOptions({ ...mutation.options, meta: { time: 1000 } }) + existingMutation.setOptions({ + ...existingMutation.options, + meta: { time: 1000 }, + }) rendered.rerender() expect( rendered.getByText( @@ -345,7 +348,7 @@ describe('useMutationState', () => { : 'result: [{"time":1000}]', ), ).toBeInTheDocument() - expect(mutation.state).toBe(state) + expect(existingMutation.state).toBe(state) expect(onCacheChange).not.toHaveBeenCalled() unsubscribe() },