test(vue-query/useQueryClient): use named imports and 'importOriginal' in the 'vue-demi' mock by sukvvon · Pull Request #12297 · TanStack/query

sukvvon · 2026-10-23T08:30:00Z

🎯 Changes

Import inject and hasInjectionContext by name instead of the VueDemi namespace, which was flagged by cspell.
Use the importOriginal argument of vi.mock instead of vi.importActual<typeof VueDemi>.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Updated the Vue Query client test setup. This change is limited to internal testing and does not alter application behavior or introduce changes visible to end users.

…' in the 'vue-demi' mock

changeset-bot · 2026-10-23T08:30:10Z

⚠️ No Changeset found

Latest commit: aa23fc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-23T08:30:28Z

View your CI Pipeline Execution ↗ for commit aa23fc8

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 57s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	4s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-23 08:35:08 UTC

github-actions · 2026-10-23T08:30:59Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-23T08:31:36Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: test/vue-query-use-query-client-vue-demi-mock
File: .coderabbit.yaml
Commit: aa23fc8
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: 7bb1a026-12eb-4141-815e-3cb6d09e7861

📥 Commits

Reviewing files that changed from the base of the PR and between 6bdeb13 and aa23fc8.

📒 Files selected for processing: 1

packages/vue-query/src/__tests__/useQueryClient.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

The useQueryClient test now imports Vue injection functions directly. Its mock factory uses importOriginal(), and its spies use the named imports.

Changes: Vue Query test mock

Layer / File(s)	Summary
Update test imports and spies `packages/vue-query/src/__tests__/useQueryClient.test.ts`	The test imports `hasInjectionContext` and `inject` directly, uses `importOriginal()` in its mock factory, and spies on the imported functions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Refactor

Suggested reviewers: alexanderkaran

Merge Risk: ⚪ Minimal · up to aa23f

This test-only change is mergeable with no identified release or runtime impact.

Pre-merge checks: 5

Check name	Status	Explanation
Title check		The title clearly and concisely describes both test changes: named imports and the use of importOriginal in the vue-demi mock.
Description check		The description includes all required template sections, explains the changes and motivation, completes the checklist, reports testing, and identifies the change as dev-only with no release impact.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-23T08:32:07Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12297

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12297

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12297

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12297

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12297

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12297

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12297

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12297

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12297

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12297

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12297

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12297

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12297

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12297

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12297

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12297

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12297

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12297

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12297

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12297

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12297

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12297

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12297

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12297

commit: aa23fc8

github-actions · 2026-10-23T08:32:19Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

test(vue-query/useQueryClient): use named imports and 'importOriginal…

aa23fc8

…' in the 'vue-demi' mock

sukvvon self-assigned this Oct 23, 2026

sukvvon merged commit 8c3c31a into main Oct 23, 2026
9 checks passed

sukvvon deleted the test/vue-query-use-query-client-vue-demi-mock branch October 23, 2026 08:44

Navigation Menu

Repository navigation

test(vue-query/useQueryClient): use named imports and 'importOriginal' in the 'vue-demi' mock - #12297

test(vue-query/useQueryClient): use named imports and 'importOriginal' in the 'vue-demi' mock#12297
sukvvon merged 1 commit into
mainfrom
test/vue-query-use-query-client-vue-demi-mock

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 23, 2026

Uh oh!

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 23, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 23, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 23, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 23, 2026

Uh oh!

github-actions Bot commented Oct 23, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 23, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 23, 2026 •

edited

Loading

coderabbitai Bot commented Oct 23, 2026 •

edited

Loading