test(preact-query/useMutation): wait for the mutation to settle after unmount and assert that no error is logged by sukvvon · Pull Request #12335 · TanStack/query

sukvvon · 2026-10-25T04:29:06Z

🎯 Changes

The test clicked mutate and unmounted the component, then ended before the mutation (sleep(10)) settled, so it checked nothing and needed an oxlint-disable-next-line vitest/expect-expect comment. Spy on console.error, advance the timers until the mutation settles, and assert that nothing is logged, then remove the comment.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage for mutations that finish after their component has unmounted, verifying that this scenario completes without console errors. This strengthens confidence in the behavior when a component is removed while a mutation is still in progress.

… unmount and assert that no error is logged

changeset-bot · 2026-10-25T04:29:12Z

⚠️ No Changeset found

Latest commit: 78fdbae

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

nx-cloud · 2026-10-25T04:29:28Z

View your CI Pipeline Execution ↗ for commit 78fdbae

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 13s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	28s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-25 04:34:22 UTC

github-actions · 2026-10-25T04:30:05Z

🚀 Changeset Version Preview

5 package(s) bumped directly, 19 bumped as dependents.

🟨 Minor bumps

Package	Version	Reason
`@tanstack/angular-query-experimental`	5.104.5 → 5.105.0	Changeset
`@tanstack/solid-query-devtools`	5.104.5 → 5.105.0	Changeset
`@tanstack/vue-query`	5.104.5 → 5.105.0	Changeset
`@tanstack/eslint-plugin-query`	5.104.5 → 5.105.0	Dependent
`@tanstack/preact-query`	5.104.5 → 5.105.0	Dependent
`@tanstack/preact-query-devtools`	5.104.5 → 5.105.0	Dependent
`@tanstack/preact-query-persist-client`	5.104.5 → 5.105.0	Dependent
`@tanstack/query-async-storage-persister`	5.104.5 → 5.105.0	Dependent
`@tanstack/query-broadcast-client-experimental`	5.104.5 → 5.105.0	Dependent
`@tanstack/query-core`	5.104.5 → 5.105.0	Dependent
`@tanstack/query-devtools`	5.104.5 → 5.105.0	Dependent
`@tanstack/query-persist-client-core`	5.104.5 → 5.105.0	Dependent
`@tanstack/query-sync-storage-persister`	5.104.5 → 5.105.0	Dependent
`@tanstack/react-query`	5.104.5 → 5.105.0	Dependent
`@tanstack/react-query-devtools`	5.104.5 → 5.105.0	Dependent
`@tanstack/react-query-next-experimental`	5.104.5 → 5.105.0	Dependent
`@tanstack/react-query-persist-client`	5.104.5 → 5.105.0	Dependent
`@tanstack/solid-query`	5.104.5 → 5.105.0	Dependent
`@tanstack/solid-query-persist-client`	5.104.5 → 5.105.0	Dependent

🟩 Patch bumps

Package	Version	Reason
`@tanstack/svelte-query-devtools`	6.3.5 → 6.3.6	Changeset
`@tanstack/vue-query-devtools`	6.3.5 → 6.3.6	Changeset
`@tanstack/lit-query`	0.2.30 → 0.2.31	Dependent
`@tanstack/svelte-query`	6.3.5 → 6.3.6	Dependent
`@tanstack/svelte-query-persist-client`	6.3.5 → 6.3.6	Dependent

coderabbitai · 2026-10-25T04:30:15Z

No actionable comments were generated in the recent review.

Recent review info

Run configuration

Source mode: Auto
Repository: TanStack/query
Branch: test/preact-query-use-mutation-unmount-assertion
File: .coderabbit.yaml
Commit: 78fdbae
Layers: Repository YAML
Review profile: CHILL
Plan: Advanced
Run ID: 178fd75a-5ad0-402e-9430-4e3cfd4808f8

Commits

Reviewing files that changed from the base of the PR and between 1eed9d9 and 78fdbae.

Files selected for processing: 1

packages/preact-query/src/__tests__/useMutation.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

Walkthrough

The unmounted-state test now waits for the mutation to complete after unmounting and verifies that no console errors were logged.

Changes: Preact mutation test

Layer / File(s)	Summary
Unmounted mutation completion `packages/preact-query/src/__tests__/useMutation.test.tsx`	The test spies on `console.error`, waits for the mutation timer after unmounting, and asserts that no errors were logged. The `expect-expect` suppression was removed.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Possibly related PRs

TanStack/query#12294: Updates a test helper in the same useMutation.test.tsx file.

Suggested reviewers: thevedanta

Merge Risk: Minimal · up to 78fdb

This test-only change presents no actionable merge risk.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title clearly identifies the test change: it waits for the mutation to settle after unmount and verifies that no error is logged.
Description check		The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, confirms local testing, confirms policy compliance, and identifies the change as dev-…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Description check

Explanation

The description includes the required Changes, Checklist, and Release Impact sections. It explains the motivation, confirms local testing, confirms policy compliance, and identifies the change as dev-only.

Finishing Touches: 💡 1

📝 Generate docstrings: 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-25T04:31:01Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@12335

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@12335

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@12335

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@12335

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@12335

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@12335

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@12335

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@12335

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@12335

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@12335

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@12335

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@12335

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@12335

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@12335

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@12335

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@12335

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@12335

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@12335

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@12335

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@12335

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@12335

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@12335

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@12335

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@12335

commit: 78fdbae

github-actions · 2026-10-25T04:31:37Z

size-limit report 📦

Path	Size
react full	11.76 KB (0%)
react minimal	8.59 KB (0%)

test(preact-query/useMutation): wait for the mutation to settle after…

78fdbae

… unmount and assert that no error is logged

sukvvon self-assigned this Oct 25, 2026

sukvvon merged commit a6211e3 into main Oct 25, 2026
9 checks passed

sukvvon deleted the test/preact-query-use-mutation-unmount-assertion branch October 25, 2026 04:40

coderabbitai Bot mentioned this pull request Oct 25, 2026

test(react-query/useMutation): assert that the mutation settles in the cache after unmount while the component state stays unchanged #12339

Merged

4 of 5 tasks

Navigation Menu

Repository navigation

test(preact-query/useMutation): wait for the mutation to settle after unmount and assert that no error is logged - #12335

test(preact-query/useMutation): wait for the mutation to settle after unmount and assert that no error is logged#12335
sukvvon merged 1 commit into
mainfrom
test/preact-query-use-mutation-unmount-assertion

sukvvon commented Oct 25, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

changeset-bot Bot commented Oct 25, 2026

Uh oh!

nx-cloud Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 25, 2026

Uh oh!

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 25, 2026

Uh oh!

github-actions Bot commented Oct 25, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

sukvvon commented Oct 25, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Oct 25, 2026

⚠️ No Changeset found

Uh oh!

nx-cloud Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 25, 2026

🚀 Changeset Version Preview

🟨 Minor bumps

🟩 Patch bumps

Uh oh!

coderabbitai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pkg-pr-new Bot commented Oct 25, 2026

Uh oh!

github-actions Bot commented Oct 25, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 25, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 25, 2026 •

edited

Loading

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading