From de92bb9b37535b1332277eea07f411df5ca9db82 Mon Sep 17 00:00:00 2001 From: Wonsuk Choi Date: Sun, 25 Oct 2026 13:32:10 +0900 Subject: [PATCH] test(query-core/streamedQuery): consume the signal with 'void context.signal' instead of an always-truthy condition, and explain the kept 'require-await' disables --- .../src/__tests__/streamedQuery.test.tsx | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/packages/query-core/src/__tests__/streamedQuery.test.tsx b/packages/query-core/src/__tests__/streamedQuery.test.tsx index dfd26644caa..15e3c8ed170 100644 --- a/packages/query-core/src/__tests__/streamedQuery.test.tsx +++ b/packages/query-core/src/__tests__/streamedQuery.test.tsx @@ -287,9 +287,8 @@ describe('streamedQuery', () => { queryFn: streamedQuery({ streamFn: (context) => { // just consume the signal - // oxlint-disable-next-line typescript/no-unnecessary-condition - const numbers = context.signal ? 3 : 0 - return createAsyncNumberGenerator(numbers) + void context.signal + return createAsyncNumberGenerator(3) }, refetchMode: 'append', }), @@ -338,9 +337,8 @@ describe('streamedQuery', () => { queryFn: streamedQuery({ streamFn: (context) => { // just consume the signal - // oxlint-disable-next-line typescript/no-unnecessary-condition - const numbers = context.signal ? 3 : 0 - return createAsyncNumberGenerator(numbers) + void context.signal + return createAsyncNumberGenerator(3) }, }), }) @@ -479,7 +477,7 @@ describe('streamedQuery', () => { queryFn: streamedQuery({ initialValue: 'initial', reducer: () => null, - // oxlint-disable-next-line typescript/require-await + // oxlint-disable-next-line typescript/require-await -- 'streamFn' needs an async iterable, and this generator has nothing to await streamFn: async function* () { yield 1 }, @@ -500,7 +498,7 @@ describe('streamedQuery', () => { retry: false, queryFn: streamedQuery({ refetchMode: 'reset', - // oxlint-disable-next-line typescript/require-await + // oxlint-disable-next-line typescript/require-await -- 'streamFn' needs an async iterable, and this generator has nothing to await streamFn: async function* () { if (shouldError) { throw error @@ -647,7 +645,7 @@ describe('streamedQuery', () => { const observer = new QueryObserver(queryClient, { queryKey: key, queryFn: streamedQuery({ - // oxlint-disable-next-line typescript/require-await + // oxlint-disable-next-line typescript/require-await -- 'streamFn' needs an async iterable, and this generator has nothing to await streamFn: async function* () { const v = [1, 2, 3] yield* v