Repository navigation
fix(start-plugin-core): reject prerender when a page fails - #8747
Closed
maricastroc wants to merge 1 commit into
Closed
maricastroc wants to merge 1 commit into
maricastroc wants to merge 1 commit into
Conversation
With `failOnError`, a failed page was rethrown inside the prerender queue. The `queue.add` promises were never observed and `Queue.start()` only resolves, so `prerender()` resolved and the error escaped as an unhandled rejection that crashed the build process without closing the preview server. Record the first failure, skip tasks that start after it, and rethrow it once the queue settles so `prerender()` rejects.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🦋 Changeset detectedLatest commit: f132811 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
failOnError, a failed page was rethrown inside the prerender queue. Thequeue.addpromises were never observed andQueue.start()only resolves, soprerender()resolved and the error escaped as an unhandled rejection that crashed the build process without closing the preview server.Record the first failure, skip tasks that start after it, and rethrow it once the queue settles so
prerender()rejects.🎯 Changes
✅ Checklist
🚀 Release Impact