fix: email digest silent failures — exit non-zero on error + fallback to latest entries

Problems:
1. notify.py and announce.py returned False on failure but never called
   sys.exit(1), so GitHub Actions marked failed runs as successful.
2. notify.py silently skipped sending when no opportunities were added
   in the last 7 days, even if the sheet had older entries. Now falls
   back to the latest entries in the sheet.
3. run.py did not propagate the return value from notify, so a failed
   email send never surfaced as a non-zero exit code.

Changes:
- notify.py: add fetch_latest_from_tab() fallback; sys.exit(1) on failure
- run.py: return notify result; sys.exit(1) if notify fails
- announce.py: sys.exit(1) on send failure

Author: kamsirichard

announce.py

@@ -14,6 +14,7 @@
 
 import argparse
 import os
+import sys
 import smtplib
 import logging
 import time
@@ -342,6 +343,9 @@ def main():
     if success and not args.force:
         _mark_as_sent()
 
+    if not success:
+        sys.exit(1)
+
 
 if __name__ == "__main__":
     main()

notify.py

@@ -12,6 +12,7 @@
 
 import os
 import re
+import sys
 import imaplib
 import smtplib
 import argparse
@@ -250,6 +251,36 @@ def fetch_recent_from_tab(tab_name, limit=25):
         return []
 
 
+def fetch_latest_from_tab(tab_name, limit=25):
+    """Fetch up to `limit` most recent entries regardless of date added."""
+    try:
+        client = _get_sheet_client()
+        ss = client.open_by_key(SPREADSHEET_ID)
+        try:
+            ws = ss.worksheet(tab_name)
+        except Exception:
+            logger.warning(f"notify: Tab '{tab_name}' not found.")
+            return []
+
+        all_values = ws.get_all_values()
+        if not all_values:
+            return []
+        raw_headers = all_values[0]
+        headers = [h.strip() for h in raw_headers]
+        rows_raw = all_values[1:]
+        rows = []
+        for r in rows_raw:
+            padded = list(r) + [""] * max(0, len(headers) - len(r))
+            rows.append(dict(zip(headers, padded[:len(headers)])))
+
+        result = rows[-limit:] if len(rows) > limit else rows
+        logger.info(f"notify: {len(result)} total entries from '{tab_name}' (fallback).")
+        return result
+    except Exception as exc:
+        logger.error(f"notify: Could not fetch '{tab_name}' — {exc}")
+        return []
+
+
 # ── Email HTML (SWElist-inspired clean format) ───────────────────────────────
 
 def _opp_list_items(opps):
@@ -515,11 +546,19 @@ def run_notify(dry_run=False):
     nigeria_opps = fetch_recent_from_tab("Nigeria",       limit=25)
     intl_opps    = fetch_recent_from_tab("International", limit=25)
 
+    if not nigeria_opps and not intl_opps:
+        logger.warning(
+            "notify: No opportunities added in the last "
+            f"{RECENT_DAYS} days. Falling back to latest entries."
+        )
+        nigeria_opps = fetch_latest_from_tab("Nigeria",       limit=25)
+        intl_opps    = fetch_latest_from_tab("International", limit=25)
+
     if not nigeria_opps and not intl_opps and not dry_run:
-        logger.warning("notify: No recent opportunities. No email sent.")
+        logger.error("notify: No opportunities found at all. No email sent.")
         return False
     if not nigeria_opps and not intl_opps:
-        logger.warning("notify: No recent opportunities; writing empty dry-run preview.")
+        logger.warning("notify: No opportunities found; writing empty dry-run preview.")
 
     recipients = build_recipient_list()
 
@@ -542,7 +581,9 @@ def main():
         help="Build email_preview.html without sending any email"
     )
     args = parser.parse_args()
-    run_notify(dry_run=args.dry_run)
+    ok = run_notify(dry_run=args.dry_run)
+    if not ok:
+        sys.exit(1)
 
 
 if __name__ == "__main__":

run.py

@@ -62,7 +62,7 @@ def run_notify(dry_run=False):
     """Read the sheet and email the digest to all subscribers."""
     sys.path.insert(0, SCRIPT_DIR)
     from notify import run_notify as _run_notify
-    _run_notify(dry_run=dry_run)
+    return _run_notify(dry_run=dry_run)
 
 
 def run_broadcast():
@@ -137,7 +137,9 @@ def main():
     elif args.cleanup:
         run_cleanup()
     elif args.notify or args.dry_run:
-        run_notify(dry_run=args.dry_run)
+        ok = run_notify(dry_run=args.dry_run)
+        if not ok:
+            sys.exit(1)
     elif args.schedule:
         run_schedule()
     else: