Week 7: Weather app

[jacquelinekellyhunt]

Here's my netifly link: https://nightcast.netlify.app/

According to the requirements we had to follow the design in the Figma file - I added the design in a comment-out section in the CSS file. I hope it's fine I wanted to test out another design - if not I can make some changes to get it approved 😊

[HIPPIEKICK]

HTML/CSS

• Consider utilising more semantic elements such as section, article etc, instead of using a lot of divs.
• Really smooth transitioning between the themes 🤩
• Make sure to test your apps on all sizes, it looks a bit too crowded and overlapping on small phones.
• One of your images appears to be broken (or rather: it doesn't exist): src="assets/design-1/cloudySun.png"

JavaScript

• Very nice that you implemented a search bar! Makes your app come to life 💃
• Well-structured and modular code, keep this up! The formatTime function is a great helper function 👍

Changes Requested

• Have another look at how your app looks like on small phones (320px, e.g. iPhone 5/SE). It looks a bit crowded

PS. I don't understand your comment:

According to the requirements we had to follow the design in the Figma file - I added the design in a comment-out section in the CSS file.

Do you mean you created two different versions, because I can't see any commented out code 👀 Either way, I'll allow it. Just make sure to try to follow the design next time, it's a great skill to learn and I'm confident you can do it 😊

[jacquelinekellyhunt]

Thank you @HIPPIEKICK for the thorough feedback! For the commented out section in the CSS, they are the lines 302-528 😊 Also made some corrections for media query, hope this resolves!

[JennieDalgren]

There is still some overlapping happening in your app on a small phone

Look at that toggle button on top of the "Weekly forecast"

mistake

[HIPPIEKICK]

There is still some overlapping happening in your app on a small phone

Look at that toggle button on top of the "Weekly forecast"