Skip to content

Weather app - Nella - #417

Open
nella-x wants to merge 8 commits into
Technigo:masterfrom
nella-x:master
Open

nella-x wants to merge 8 commits into
Technigo:masterfrom
nella-x:master

Conversation

@nella-x

@nella-x nella-x commented Sep 29, 2024

Copy link
Copy Markdown

@HIPPIEKICK HIPPIEKICK self-assigned this Oct 3, 2024

@HIPPIEKICK HIPPIEKICK left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML/CSS

  • Simple and clean HTML file. Consider using semantic elements more and keep the amount of divs down
  • I love the quirky design (haha and the name of your page)! However, remember to try to follow our design the next time we tell you to, as it's an important skill to learn.

JavaScript

  • Nice to gather all the icons in a variable! Since it's a list however, maybe it would make more sense as an array?
  • Your code definitely works like it is now, but going forward I would like you to modularize your code more and break it out into functions.

Clean Code

  • Clean up all console.logs, unused code and instructional comments from us.

Keep up the good work Nella!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants