Annas Weather App - #418
Open
Anna2024WebDev wants to merge 20 commits into
Open
Anna2024WebDev wants to merge 20 commits into
Anna2024WebDev wants to merge 20 commits into
Conversation
…eather description
…anged the city variable from const to let since you now can search on other cities than Stockholm
HIPPIEKICK
previously requested changes
Oct 3, 2024
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
Contributor
There was a problem hiding this comment.
HTML/CSS
- Very nice job following the design! Consider adding a fixed width to your
liitems to create some space in between
JavaScript
- Really good job structuring your JavaScript! You've used clear and descriptive names on most of your variables and functions
- Good idea using toLowerCase and includes for the weather conditions 👍
Clean Code
- The indentation is off in your HTML file. Also, I'd suggest you change to 2 spaces indentation in your JS file as it becomes hard to read when the indentations are this big.
- Don't mix arrow functions with the function keyword
- Since city is not a constant, it should be named in camelCase
Changes Requested
- Clean up the code as requested ☝️ Apart from that - good job!
Comment on lines
+40
to
+48
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
||
|
|
Author
There was a problem hiding this comment.
Thank you for your feedback @HIPPIEKICK! I think I have updated according to the changes requested! Best, Anna
…set if statement for night styling and changed variable from CITY to city (camelCase)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Netlify link
https://checkthe-weather.netlify.app/