Repository navigation
vulkan: skip unused RMSNorm fallback pipelines - #7133
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7133 +/- ##
==========================================
- Coverage 95.29% 95.26% -0.03%
==========================================
Files 1483 1483
Lines 504854 504979 +125
==========================================
- Hits 481094 481091 -3
- Misses 23760 23888 +128 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Binary size comparison The binary size change of libncnn.so (bytes)
Commit: |
Create the subgroup reducers and the square/sum4/mean fallback pipelines in mutually exclusive branches, matching LayerNorm. Keep the shared coeffs/norm pipelines unconditional.
This avoids allocating ten unused fallback Pipeline wrappers when the validated subgroup path is enabled.
Follow-up to #6755 and #6755 (comment).
Validation:
SwiftShader supports subgroup arithmetic but not fp16 storage/arithmetic, so the existing dedicated fp16a cases were skipped. No hardware startup-time measurements were made.