Stop reading the word 'URL' in a description as an env var - #2312
Open
NotAFlightRisk wants to merge 1 commit into
Open
Stop reading the word 'URL' in a description as an env var#2312NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live index is currently handing out this config:
Checked 2026-09-11, with
/healthreporting the index on the same commit as main, so that's not a stale build. There is noURLvariable. Its description says:Someone copying that config into Claude Desktop is told to set a variable the project doesn't have. They may ignore it, or waste time searching the README before assuming the listing is broken or theyve missed a setup step. The profile repeats the fictional name under install env, so it offers no correction.
The tokenizer extracts all-caps words, then a suffix regex decides which look like credentails. With no left anchor, the bare suffix
URLmatches itself. Real names includingAPI_KEY,GITHUB_TOKENandLNURLstill match.The made-up name only reaches install config when an entry has a lauch command, though it appears in
install.envon profiles either way. This doesn't make the heuristic clever:CURLstill passes. There aren't any in the catalog now, and that could be tightened later with a real word list.With the three source copies reverted, the fixture fails with
expected [ 'API_KEY', 'URL' ] to deeply equal [ 'API_KEY' ]. Put back,npx vitest runpasses 13 files and 77 tests,node --test '.github/scripts/*.test.mjs'passes 74 with 0 failures, andnpm run typecheckis clean. A full rebuild keeps the same entries, drops onlyURL, and adds nothing.All three source copies need the fix. The scripts write metadata sidecars which overide catalog detection, so leaving either unchanged can write
URLback and make it stick. Some sidecars underdata/server-metadata/already carryURLininstall.env,github-octotrip-rental-cars-79f20a09among them. Nothing here touchesdata/, so they keep it until the next regeneration.