Skip to content

Stop reading the word 'URL' in a description as an env var #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilsonccccc merged 1 commit into from
Sep 11, 2026
Merged

Stop reading the word 'URL' in a description as an env var #2312

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/scripts/create-add-server-pr.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,7 +716,7 @@ function normalizeMetadataScalar(value) {

function extractEnvVars(value) {
const matches = value.match(/\b[A-Z][A-Z0-9_]{2,}\b/g) ?? [];
return unique(matches.filter((match) => /(KEY|TOKEN|SECRET|PASSWORD|ENDPOINT|URL)$/.test(match)));
return unique(matches.filter((match) => /^.+(?:KEY|TOKEN|SECRET|PASSWORD|ENDPOINT|URL)$/.test(match)));
}

function extractEndpoint(value) {
Expand Down
2 changes: 1 addition & 1 deletion .github/scripts/create-improve-metadata-pr.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ function normalizeMetadataScalar(value) {

function extractEnvVars(value) {
const matches = value.match(/\b[A-Z][A-Z0-9_]{2,}\b/g) ?? [];
return unique(matches.filter((match) => /(KEY|TOKEN|SECRET|PASSWORD|ENDPOINT|URL)$/.test(match)));
return unique(matches.filter((match) => /^.+(?:KEY|TOKEN|SECRET|PASSWORD|ENDPOINT|URL)$/.test(match)));
}

function extractFirstUrl(value) {
Expand Down
2 changes: 1 addition & 1 deletion packages/catalog-builder/src/buildCatalog.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ function extractInstallCommands(text: string): string[] {

function extractEnvVars(text: string): string[] {
const matches = text.match(/\b[A-Z][A-Z0-9_]{2,}\b/g) ?? [];
return unique(matches.filter((match) => /(KEY|TOKEN|SECRET|PASSWORD|ENDPOINT|URL)$/.test(match)));
return unique(matches.filter((match) => /^.+(?:KEY|TOKEN|SECRET|PASSWORD|ENDPOINT|URL)$/.test(match)));
}

function extractEndpoint(text: string): string | null {
Expand Down
2 changes: 1 addition & 1 deletion packages/catalog-builder/test/buildCatalog.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ describe("buildCatalogFromMarkdown", () => {
"## Experimental",
[
"- [Metadata MCP](https://example.com/metadata-mcp):",
"Run `npx metadata-mcp` with API_KEY for OAuth-enabled Claude usage.",
"Run `npx metadata-mcp` with API_KEY against any URL for OAuth-enabled Claude usage.",
"Includes 13 tools under MIT license.",
].join(" "),
].join("\n");
Expand Down
Loading