fix(ble): decode whitelistOperationStatus in Commands._command VCSEC reply

A WhitelistOperation sent through the signed-command path reported
{"result": True} even when the vehicle rejected it (e.g.
NO_PERMISSION_TO_ADD), because the OPERATIONSTATUS_OK branch never
inspected commandStatus.whitelistOperationStatus. Reuse the same
WHITELIST_OPERATION_STATUS mapping bluetooth.py's
_raise_for_whitelist_reply already uses.

Bumps version to 1.14.1 (bug fix).

Author: Bre77

pyproject.toml

@@ -4,7 +4,7 @@ requires = ["setuptools>=77.0"]
 
 [project]
 name = "tesla_fleet_api"
-version = "1.14.0"
+version = "1.14.1"
 license = "Apache-2.0"
 description = "Tesla Fleet API library for Python"
 readme = "README.md"

tesla_fleet_api/__init__.py

@@ -1,7 +1,7 @@
 """Tesla Fleet API"""
 
 __author__ = "hello@teslemetry.com"
-__version__ = "1.14.0"
+__version__ = "1.14.1"
 
 from tesla_fleet_api.const import Region, is_valid_region
 from tesla_fleet_api.funnel import (

tesla_fleet_api/tesla/vehicle/commands.py

@@ -26,11 +26,13 @@
 from tesla_fleet_api.exceptions import (
     MESSAGE_FAULTS,
     SIGNED_MESSAGE_INFORMATION_FAULTS,
+    WHITELIST_OPERATION_STATUS,
     NotOnWhitelistFault,
     SessionInfoAuthenticationFault,
     SignedCommandResponseReplayed,
     SigningDisabled,
     TeslaFleetError,
+    WhitelistOperationStatus,
     # TeslaFleetMessageFaultInvalidSignature,
     TeslaFleetMessageFaultIncorrectEpoch,
     TeslaFleetMessageFaultInvalidTokenOrCounter,
@@ -788,6 +790,16 @@ async def _command(
                     vcsec.commandStatus.operationStatus
                     == OperationStatus_E.OPERATIONSTATUS_OK
                 ):
+                    info = vcsec.commandStatus.whitelistOperationStatus.whitelistOperationInformation
+                    if info:
+                        if info < len(WHITELIST_OPERATION_STATUS):
+                            exception = WHITELIST_OPERATION_STATUS[info]
+                            if exception:
+                                raise exception
+                        else:
+                            raise WhitelistOperationStatus(
+                                f"Unknown whitelist operation failure: {info}"
+                            )
                     return {"response": {"result": True, "reason": ""}}
                 elif (
                     vcsec.commandStatus.operationStatus

tests/test_vcsec_whitelist_status_decode.py

@@ -0,0 +1,67 @@
+"""``Commands._command()`` must decode ``whitelistOperationStatus`` on a VCSEC
+reply, not just ``operationStatus`` - a ``WhitelistOperation`` the vehicle
+rejects still replies with ``OPERATIONSTATUS_OK`` at the outer level.
+"""
+
+from __future__ import annotations
+
+from tesla_fleet_api.exceptions import WhitelistOperationNoPermissionToAdd
+from tesla_protocol.command.universal_message_pb2 import (
+    Destination,
+    Domain,
+    RoutableMessage,
+)
+from tesla_protocol.command.vcsec_pb2 import (
+    CommandStatus,
+    FromVCSECMessage,
+    OperationStatus_E,
+    WHITELISTOPERATION_INFORMATION_NO_PERMISSION_TO_ADD,
+    WhitelistOperation_status,
+)
+
+from ble_mocked_transport import MockedBleTransportTestCase
+
+
+def whitelist_op_reply(info: int) -> RoutableMessage:
+    """A VCSEC reply to a ``WhitelistOperation``: outer status OK, op status in ``info``."""
+    body = FromVCSECMessage(
+        commandStatus=CommandStatus(
+            operationStatus=OperationStatus_E.OPERATIONSTATUS_OK,
+            whitelistOperationStatus=WhitelistOperation_status(
+                whitelistOperationInformation=info
+            ),
+        )
+    )
+    return RoutableMessage(
+        from_destination=Destination(domain=Domain.DOMAIN_VEHICLE_SECURITY),
+        protobuf_message_as_bytes=body.SerializeToString(),
+    )
+
+
+class VcsecWhitelistStatusDecodeTest(MockedBleTransportTestCase):
+    async def test_rejected_whitelist_operation_raises(self) -> None:
+        """A vehicle-rejected key add must raise, not report ``result: True``."""
+        vehicle, send = self.make_vehicle()
+        send.return_value = whitelist_op_reply(
+            WHITELISTOPERATION_INFORMATION_NO_PERMISSION_TO_ADD
+        )
+
+        with self.assertRaises(WhitelistOperationNoPermissionToAdd):
+            await vehicle._command(
+                Domain.DOMAIN_VEHICLE_SECURITY,
+                b"",
+                expects_data=False,
+            )
+
+    async def test_accepted_whitelist_operation_succeeds(self) -> None:
+        """A zero/absent whitelist status leaves the existing success path intact."""
+        vehicle, send = self.make_vehicle()
+        send.return_value = whitelist_op_reply(0)
+
+        result = await vehicle._command(
+            Domain.DOMAIN_VEHICLE_SECURITY,
+            b"",
+            expects_data=False,
+        )
+
+        self.assertEqual(result, {"response": {"result": True, "reason": ""}})