Store class in closures to allow super super calls - #301
Open
Uks2 wants to merge 1 commit into
Open
Conversation
Owner
|
@Uks2 Thanks for contributing to the project! Using the defining function’s context rather than the instance’s immediate parent makes more sense. |
When performing `super()` or `super.something()` calls, the parent class used to be found from `self`. This would always return `self`'s immediate parent when meant that if you called `super.x()` and then the parent class function tried to call its `super.x()`, you would end up just calling the same function again. Now, the closure structure has a `Class*` field, filled in when the function is bound, and this is used to find the parent of the method that actually being run.
Author
|
That force push should fix the style error |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes how the parent class is found when doing
supercalls. It now uses the parent class of the function that thesupercall appears in, rather than the immediate parent ofself. This means that you can usesuperin functions that are themselves called usingsuper.