Skip to content

Commit 12f3cfb

Browse files
oharboeclaude
andcommitted
Remove REMOVE_ABC_BUFFERS support
floorplan.tcl now always runs repair_timing_helper. The variable is dropped from variables.yaml, variables.json and FlowVariables.md. Designs are deliberately not touched here; they are handled by #4575, #4576, #4577, #4578 and #4579. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
1 parent c63a606 commit 12f3cfb

4 files changed

Lines changed: 3 additions & 27 deletions

File tree

‎docs/user/FlowVariables.md‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,6 @@ configuration file.
246246
| <a name="PWR_NETS_VOLTAGES"></a>PWR_NETS_VOLTAGES| Used for IR Drop calculation.| |
247247
| <a name="RCX_RULES"></a>RCX_RULES| RC Extraction rules file path.| |
248248
| <a name="RECOVER_POWER"></a>RECOVER_POWER| Specifies how many percent of paths with positive slacks can be slowed for power savings [0-100].| 0|
249-
| <a name="REMOVE_ABC_BUFFERS"></a>REMOVE_ABC_BUFFERS (deprecated)| Remove abc buffers from the netlist. If timing repair in floorplanning is taking too long, use a SETUP/HOLD_SLACK_MARGIN to terminate timing repair early instead of using REMOVE_ABC_BUFFERS or set SKIP_LAST_GASP=1.| 0|
250249
| <a name="REMOVE_CELLS_FOR_LEC"></a>REMOVE_CELLS_FOR_LEC| String patterns directly passed to write_verilog -remove_cells <> for lec checks.| |
251250
| <a name="REPAIR_PDN_VIA_LAYER"></a>REPAIR_PDN_VIA_LAYER| Remove power grid vias which generate DRC violations after detailed routing.| |
252251
| <a name="REPORT_CLOCK_SKEW"></a>REPORT_CLOCK_SKEW| Report clock skew as part of reporting metrics, starting at CTS, before which there is no clock skew. This metric can be quite time-consuming, so it can be useful to disable.| 1|
@@ -431,7 +430,6 @@ configuration file.
431430
- [PRE_MACRO_PLACE_TCL](#PRE_MACRO_PLACE_TCL)
432431
- [PRE_PDN_TCL](#PRE_PDN_TCL)
433432
- [PRE_TAPCELL_TCL](#PRE_TAPCELL_TCL)
434-
- [REMOVE_ABC_BUFFERS](#REMOVE_ABC_BUFFERS)
435433
- [ROUTING_LAYER_ADJUSTMENT](#ROUTING_LAYER_ADJUSTMENT)
436434
- [RTLMP_AREA_WT](#RTLMP_AREA_WT)
437435
- [RTLMP_ARGS](#RTLMP_ARGS)

‎flow/scripts/floorplan.tcl‎

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ source_env_var_if_exists FOOTPRINT_TCL
114114
log_cmd set_dont_use $::env(DONT_USE_CELLS)
115115

116116
# The transforms below (repair_tie_fanout, replace_arith_modules,
117-
# remove_buffers, repair_timing_helper) look like synthesis-stage
117+
# repair_timing_helper) look like synthesis-stage
118118
# operations: they all act on the netlist and don't touch placement.
119119
# But they DO depend on having a floorplan in place — initialize_floorplan
120120
# above placed the bterms on the die boundary and set_routing_layers
@@ -151,13 +151,8 @@ if { [env_var_equals SWAP_ARITH_OPERATORS 1] } {
151151
log_cmd replace_arith_modules
152152
}
153153

154-
if { $::env(REMOVE_ABC_BUFFERS) } {
155-
# remove buffers inserted by yosys/abc
156-
log_cmd remove_buffers
157-
} else {
158-
# Skip clone & split
159-
repair_timing_helper -setup -skip_last_gasp -sequence "unbuffer,sizeup,swap,vt_swap"
160-
}
154+
# Skip clone & split
155+
repair_timing_helper -setup -skip_last_gasp -sequence "unbuffer,sizeup,swap,vt_swap"
161156

162157
puts "Default units for flow"
163158
report_units

‎flow/scripts/variables.json‎

Lines changed: 0 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎flow/scripts/variables.yaml‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -507,15 +507,6 @@ BUFFER_PORTS_ARGS:
507507
Specify arguments to the buffer_ports call during placement. Only used if DONT_BUFFER_PORTS=0.
508508
stages:
509509
- place
510-
REMOVE_ABC_BUFFERS:
511-
description: >
512-
Remove abc buffers from the netlist. If timing repair in floorplanning is
513-
taking too long, use a SETUP/HOLD_SLACK_MARGIN to terminate timing repair early
514-
instead of using REMOVE_ABC_BUFFERS or set SKIP_LAST_GASP=1.
515-
stages:
516-
- floorplan
517-
deprecated: 1
518-
default: 0
519510
BALANCE_ROWS:
520511
description: |
521512
Balance rows during placement.

0 commit comments

Comments
 (0)