Skip to content

Commit bcaac60

Browse files
committed
flow: Add SETUP_REPAIR_PHASES to select repair_timing phases
repair_timing selects its setup repair pipeline with -phases, but ORFS had no way to pass it, so a design could not opt into the experimental PARALLEL_EVAL policy. Add SETUP_REPAIR_PHASES, passed as -phases by repair_timing_helper in the same way SETUP_MOVE_SEQUENCE is passed as -sequence. It applies to every repair_timing_helper call (floorplan, place, cts and grt). When unset, repair_timing keeps its default phases, so no design changes. Signed-off-by: Jaehyun Kim <jhkim@precisioninno.com>
1 parent 0fcc418 commit bcaac60

4 files changed

Lines changed: 26 additions & 0 deletions

File tree

‎docs/user/FlowVariables.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,7 @@ configuration file.
277277
| <a name="SEAL_GDS"></a>SEAL_GDS| Seal macro to place around the design.| |
278278
| <a name="SEC_CHECK"></a>SEC_CHECK| Perform a sequential equivalence check between the initial synthesis netlist and final netlist with the Kepler Formal PDR engine. If this fails, report an issue to OpenROAD.| 0|
279279
| <a name="SETUP_MOVE_SEQUENCE"></a>SETUP_MOVE_SEQUENCE| Passed as -sequence to repair_timing. This should be a string of move keywords separated by commas.| |
280+
| <a name="SETUP_REPAIR_PHASES"></a>SETUP_REPAIR_PHASES| Passed as -phases to repair_timing. This should be a string of setup repair phase names separated by spaces. Set to PARALLEL_EVAL to repair setup timing with the experimental parallel evaluation policy. When unset, repair_timing runs its default phases.| |
280281
| <a name="SETUP_SLACK_MARGIN"></a>SETUP_SLACK_MARGIN| Specifies a time margin for the slack when fixing setup violations. This option allows you to overfix or underfix(negative value, terminate retiming before 0 or positive slack). See HOLD_SLACK_MARGIN for more details.| 0|
281282
| <a name="SKIP_ANTENNA_REPAIR"></a>SKIP_ANTENNA_REPAIR| Skips antenna repair entirely.| 0|
282283
| <a name="SKIP_ANTENNA_REPAIR_POST_DRT"></a>SKIP_ANTENNA_REPAIR_POST_DRT| Skips antenna repair post-detailed routing.| 0|
@@ -457,6 +458,7 @@ configuration file.
457458
- [RTLMP_RPT_DIR](#RTLMP_RPT_DIR)
458459
- [RTLMP_WIRELENGTH_WT](#RTLMP_WIRELENGTH_WT)
459460
- [SETUP_MOVE_SEQUENCE](#SETUP_MOVE_SEQUENCE)
461+
- [SETUP_REPAIR_PHASES](#SETUP_REPAIR_PHASES)
460462
- [SETUP_SLACK_MARGIN](#SETUP_SLACK_MARGIN)
461463
- [SKIP_BUFFER_REMOVAL](#SKIP_BUFFER_REMOVAL)
462464
- [SKIP_CRIT_VT_SWAP](#SKIP_CRIT_VT_SWAP)
@@ -516,6 +518,7 @@ configuration file.
516518
- [PRE_RESIZE_TCL](#PRE_RESIZE_TCL)
517519
- [REPORT_ENDPOINT_SLACK](#REPORT_ENDPOINT_SLACK)
518520
- [ROUTING_LAYER_ADJUSTMENT](#ROUTING_LAYER_ADJUSTMENT)
521+
- [SETUP_REPAIR_PHASES](#SETUP_REPAIR_PHASES)
519522
- [SKIP_REPORT_METRICS](#SKIP_REPORT_METRICS)
520523
- [TNS_END_PERCENT](#TNS_END_PERCENT)
521524

@@ -540,6 +543,7 @@ configuration file.
540543
- [REPORT_CLOCK_SKEW](#REPORT_CLOCK_SKEW)
541544
- [REPORT_ENDPOINT_SLACK](#REPORT_ENDPOINT_SLACK)
542545
- [SETUP_MOVE_SEQUENCE](#SETUP_MOVE_SEQUENCE)
546+
- [SETUP_REPAIR_PHASES](#SETUP_REPAIR_PHASES)
543547
- [SETUP_SLACK_MARGIN](#SETUP_SLACK_MARGIN)
544548
- [SKIP_BUFFER_REMOVAL](#SKIP_BUFFER_REMOVAL)
545549
- [SKIP_CRIT_VT_SWAP](#SKIP_CRIT_VT_SWAP)
@@ -571,6 +575,7 @@ configuration file.
571575
- [REPORT_ENDPOINT_SLACK](#REPORT_ENDPOINT_SLACK)
572576
- [ROUTING_LAYER_ADJUSTMENT](#ROUTING_LAYER_ADJUSTMENT)
573577
- [SETUP_MOVE_SEQUENCE](#SETUP_MOVE_SEQUENCE)
578+
- [SETUP_REPAIR_PHASES](#SETUP_REPAIR_PHASES)
574579
- [SETUP_SLACK_MARGIN](#SETUP_SLACK_MARGIN)
575580
- [SKIP_ANTENNA_REPAIR](#SKIP_ANTENNA_REPAIR)
576581
- [SKIP_BUFFER_REMOVAL](#SKIP_BUFFER_REMOVAL)

‎flow/scripts/util.tcl‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ proc repair_timing_helper { args } {
3232
append_env_var additional_args SETUP_SLACK_MARGIN -setup_margin 1
3333
append_env_var additional_args HOLD_SLACK_MARGIN -hold_margin 1
3434
append_env_var additional_args SETUP_MOVE_SEQUENCE -sequence 1
35+
append_env_var additional_args SETUP_REPAIR_PHASES -phases 1
3536
append_env_var additional_args TNS_END_PERCENT -repair_tns 1
3637
append_env_var additional_args SKIP_PIN_SWAP -skip_pin_swap 0
3738
append_env_var additional_args SKIP_GATE_CLONING -skip_gate_cloning 0

‎flow/scripts/variables.json‎

Lines changed: 9 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎flow/scripts/variables.yaml‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -858,6 +858,17 @@ SETUP_MOVE_SEQUENCE:
858858
- cts
859859
- floorplan
860860
- grt
861+
SETUP_REPAIR_PHASES:
862+
description: >
863+
Passed as -phases to repair_timing. This should be a string of setup
864+
repair phase names separated by spaces. Set to PARALLEL_EVAL to repair
865+
setup timing with the experimental parallel evaluation policy. When
866+
unset, repair_timing runs its default phases.
867+
stages:
868+
- cts
869+
- floorplan
870+
- grt
871+
- place
861872
SKIP_GATE_CLONING:
862873
description: >
863874
Do not use gate cloning transform to fix timing violations (default: use

0 commit comments

Comments
 (0)