Skip to content

Commit c841eea

Browse files
committed
cts.tcl: drop the 4_1_error.odb written when detailed placement fails
detailed_placement fails with its own error, and the step fails with it. The two catch blocks around it saved a debug checkpoint under a name nothing reads; a checkpoint is now an ad-hoc orfs_write_db line added for the session, and cts.tcl says only what CTS does. EndpointSlackTracking.md named 4_1_error.odb as its example and said *-failed .odb files get no snapshot; orfs_write_db snapshots every .odb it writes, so it now says so. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
1 parent e54d0af commit c841eea

2 files changed

Lines changed: 4 additions & 12 deletions

File tree

‎docs/contrib/EndpointSlackTracking.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ Every step then writes `$(REPORTS_DIR)/<step>_endpoint_slack.json`, e.g.
2424
It works in the single-process `flow/scripts/flow.tcl` flow as well. Steps
2525
that just copy their input (`orfs_copy_db`, e.g. `5_3_fillcell` without fill
2626
cells) re-time the design if it is loaded, or else copy the previous step's
27-
snapshot. Intermediate `.odb` files written through `orfs_write_db` (e.g. CTS's
28-
`4_1_error.odb`) also get a snapshot; `*-failed` ones don't.
27+
snapshot. Other `.odb` files written through `orfs_write_db`, such as a
28+
step's `<step>-failed.odb`, also get a snapshot.
2929

3030
A placed step is timed with the parasitics OpenROAD has for it: a bare
3131
`estimate_parasitics` estimates from the global routes when there are any,

‎flow/scripts/cts.tcl‎

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,7 @@ set_placement_padding -global \
3939
-left $::env(CELL_PAD_IN_SITES_DETAIL_PLACEMENT) \
4040
-right $::env(CELL_PAD_IN_SITES_DETAIL_PLACEMENT)
4141

42-
set result [catch { detailed_placement_helper -quiet } msg]
43-
if { $result != 0 } {
44-
orfs_write_db $::env(RESULTS_DIR)/4_1_error.odb
45-
error "Detailed placement failed in CTS: $msg"
46-
}
42+
detailed_placement_helper -quiet
4743

4844
log_cmd estimate_parasitics
4945

@@ -60,11 +56,7 @@ if { !$::env(SKIP_CTS_REPAIR_TIMING) } {
6056
run_lec_test 4_rsz 4_before_rsz_lec.v 4_after_rsz_lec.v
6157
}
6258

63-
set result [catch { detailed_placement_helper -quiet } msg]
64-
if { $result != 0 } {
65-
orfs_write_db $::env(RESULTS_DIR)/4_1_error.odb
66-
error "Detailed placement failed in CTS: $msg"
67-
}
59+
detailed_placement_helper -quiet
6860

6961
log_cmd check_placement -placeable -verbose
7062

0 commit comments

Comments
 (0)