You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
move variables.json update to post-merge automatic commit action along with linting and formatting #4180
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remove the Stale label or comment to keep it open.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remove the Stale label or comment to keep it open.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remove the Stale label or comment to keep it open.
@vvbandeira Ideally we could simply stop generating variables.json by requiring it in host Python and using PYTHON_EXE consistently. I could not find anything in the code that stated why this is not an option. #4721 shows that only Debian rodete doesn't install it in the install scripts for ORFS, I don't know if that's because it is impossible or because it isn't done or because a choice was made for reasons.
Proposal: after November 1, when ORFS is Bazel-only, shrink YAML handling to one tiny tool.
variables.json has spread into git, CI, the setup scripts and the PyYAML install matrix. OpenROAD already depends on yaml-cpp for its 3DBlox readers (read_3dbv/read_3dbx), so a yaml2json built on it adds no new dependency and needs nothing from the host.
PR 1, OpenROAD: add yaml2json, a small cc_binary on yaml-cpp, and include it in bazel run //:install, so it lands in <prefix>/bin next to openroad. OpenROAD already depends on yaml-cpp, so there's no additional dependency in OpenROAD.
PR 2, ORFS (after PR 1 is bumped in):
Install it with OpenROAD:build_openroad.sh, etc/DockerHelper.sh and the Dockerfiles ship yaml2json wherever they ship openroad. variables.mk sets YAML2JSON the same way it sets OPENROAD_EXE, from PATH or from tools/install/OpenROAD/bin.
Wire it up:$(YAML2JSON) variables.yaml | $(PYTHON_EXE) <reader>.py. The readers are defaults.py (variables.mk), non_stage_variables.py (util.tcl), util/stage_art.py (flow.sh) and generate-variables-docs.py. Each reads stdin and fails on empty input.
Delete and stop thinking about:
flow/scripts/variables.json and its .gitattributes entry
flow/scripts/yaml_to_json.py
the "Check variables.json is up to date" CI step and the PyYAML venv it installs
pyyaml in etc/requirements-common.in and its lock file, and python3-yaml in DependencyInstaller.sh, along with the question of which platforms install it
Both PRs are mechanical; an AI can carry them out.
Activity
github-actions commentedon Jun 22, 2026
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remove the
Stalelabel or comment to keep it open.sparsh-karna commentedon Jun 23, 2026
Hi @maliberty, @oharboe , can i work on this issue?
github-actions commentedon Aug 23, 2026
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remove the
Stalelabel or comment to keep it open.github-actions commentedon Oct 23, 2026
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 21 days if no further activity occurs. Remove the
Stalelabel or comment to keep it open.oharboe commentedon Oct 23, 2026
@vvbandeira Ideally we could simply stop generating variables.json by requiring it in host Python and using PYTHON_EXE consistently. I could not find anything in the code that stated why this is not an option. #4721 shows that only Debian rodete doesn't install it in the install scripts for ORFS, I don't know if that's because it is impossible or because it isn't done or because a choice was made for reasons.
oharboe commentedon Oct 23, 2026
Proposal: after November 1, when ORFS is Bazel-only, shrink YAML handling to one tiny tool.
variables.jsonhas spread into git, CI, the setup scripts and the PyYAML install matrix. OpenROAD already depends on yaml-cpp for its 3DBlox readers (read_3dbv/read_3dbx), so ayaml2jsonbuilt on it adds no new dependency and needs nothing from the host.PR 1, OpenROAD: add
yaml2json, a smallcc_binaryon yaml-cpp, and include it inbazel run //:install, so it lands in<prefix>/binnext toopenroad. OpenROAD already depends on yaml-cpp, so there's no additional dependency in OpenROAD.PR 2, ORFS (after PR 1 is bumped in):
build_openroad.sh,etc/DockerHelper.shand the Dockerfiles shipyaml2jsonwherever they shipopenroad.variables.mksetsYAML2JSONthe same way it setsOPENROAD_EXE, fromPATHor fromtools/install/OpenROAD/bin.$(YAML2JSON) variables.yaml | $(PYTHON_EXE) <reader>.py. The readers aredefaults.py(variables.mk),non_stage_variables.py(util.tcl),util/stage_art.py(flow.sh) andgenerate-variables-docs.py. Each reads stdin and fails on empty input.flow/scripts/variables.jsonand its.gitattributesentryflow/scripts/yaml_to_json.pypyyamlinetc/requirements-common.inand its lock file, andpython3-yamlinDependencyInstaller.sh, along with the question of which platforms install itBoth PRs are mechanical; an AI can carry them out.
maliberty commentedon Oct 25, 2026
11/1 is when OR goes bazel only, not ORFS.
oharboe commentedon Oct 25, 2026
Thanks! Typo in suggestion. The option above still applies.
flow: run variables.json readers through PYTHON_EXE
oharboe commentedon Nov 3, 2026
#4721 and the move to bazel only for OpenROAD paves the way to prune more dependencies, but we haven't done it yet.