Skip to content

fix: use SDC_FILE_EXTRA for mock-cpu util.tcl sourcing - #4093

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:fix-mock-cpu-sourcing
Apr 6, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:fix-mock-cpu-sourcing

Conversation

@oharboe

@oharboe oharboe commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

The constraint.sdc used a hardcoded $::env(DESIGN_HOME) path and io.tcl tried two relative paths with file-exists guards. Both are fragile and break in sandboxed build environments.

Use SDC_FILE_EXTRA to declare the dependency in config.mk and source $::env(SDC_FILE_EXTRA) for a portable path in both files.

The constraint.sdc used a hardcoded $::env(DESIGN_HOME) path and
io.tcl tried two relative paths with file-exists guards. Both are
fragile and break in sandboxed build environments.

Use SDC_FILE_EXTRA to declare the dependency in config.mk and
source $::env(SDC_FILE_EXTRA) for a portable path in both files.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe requested a review from maliberty April 1, 2026 04:35
@oharboe

oharboe commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator Author

Also this will be explicitly supported in bazel-orfs to set up the dependency.

@oharboe

oharboe commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator Author

@maliberty Aha! microwatt is flaky, didn't change it in this PR.

05:49:19  [ERROR] globalroute__antenna_diodes_count fail test: 3224 <= 2635

oharboe added a commit to oharboe/OpenROAD-flow-scripts that referenced this pull request Apr 2, 2026
Use SDC_FILE_EXTRA variable instead of hardcoded paths to source
mock-array/util.tcl. This works correctly in both Make and Bazel.

Cherry-pick of PR The-OpenROAD-Project#4093.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe added a commit to oharboe/OpenROAD-flow-scripts that referenced this pull request Apr 2, 2026
Use SDC_FILE_EXTRA variable instead of hardcoded paths to source
mock-array/util.tcl. This works correctly in both Make and Bazel.

Cherry-pick of PR The-OpenROAD-Project#4093.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe added a commit to oharboe/OpenROAD-flow-scripts that referenced this pull request Apr 3, 2026
Use SDC_FILE_EXTRA variable instead of hardcoded paths to source
mock-array/util.tcl. This works correctly in both Make and Bazel.

Cherry-pick of PR The-OpenROAD-Project#4093.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe added a commit to oharboe/OpenROAD-flow-scripts that referenced this pull request Apr 4, 2026
Use SDC_FILE_EXTRA variable instead of hardcoded paths to source
mock-array/util.tcl. This works correctly in both Make and Bazel.

Cherry-pick of PR The-OpenROAD-Project#4093.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@maliberty

Copy link
Copy Markdown
Member

mock-cpu passed so I assume the other failures are unrelated.

@maliberty
maliberty merged commit ba36e76 into The-OpenROAD-Project:master Apr 6, 2026
7 of 8 checks passed
@oharboe
oharboe deleted the fix-mock-cpu-sourcing branch April 19, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants