Repository navigation
Conversation
…re actionable Signed-off-by: Augusto Berndt <augusto.berndt@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request improves the error reporting in flow/scripts/util.tcl when the placement density exceeds 1.0 by providing a detailed breakdown of the calculation and suggesting actionable remedies. The review feedback points out a boundary condition bug where a place_density_lb of exactly 0.99 incorrectly triggers an empty max_addon_str, and suggests changing the condition from >= 0.99 to > 0.99.
| "Place density exceeds 1.0 (current PLACE_DENSITY_LB_ADDON = \ | ||
| $::env(PLACE_DENSITY_LB_ADDON)). Please check if the value of \ | ||
| PLACE_DENSITY_LB_ADDON is between 0 and 0.99." | ||
| if { $place_density_lb >= 0.99 } { |
There was a problem hiding this comment.
When place_density_lb is exactly 0.99, a PLACE_DENSITY_LB_ADDON value of 0 actually works (resulting in place_density = 1.0, which does not exceed the limit of 1.0). However, using >= 0.99 here causes max_addon_str to be empty, leading to an incorrect error message stating that no value works. Changing the condition to > 0.99 correctly allows max_addon_str to be calculated as 0.00 when place_density_lb is exactly 0.99.
if { $place_density_lb > 0.99 } {
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
|
Is this a linting step that runs before the flow? |
It is not. It runs at stage 3-1 (gpl without IOs), and at macro_place_util.tcl (stage 2-4 I believe). This PR relates to the discussion: #4500 I was also trying to think of a way to modify the input values automatically, although the parameters seem a little restricted to the user. For example, I am not sure we should change padding size or core dimensions because of a failed placement density calculation. |
make placement density with lower bound calculation error more informative and more actionable.
Example: