Repository navigation
build: install OpenROAD with Bazel - #4527
Conversation
OpenROAD Build.sh owns both compilation and installation. Remove the CMake-only argument path and use its Bazel install prefix in the ORFS images. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request refactors the OpenROAD build script to use Bash arrays for managing build arguments, simplifying the build process by delegating directly to Build.sh. It also removes the openroadVersion build argument from the Docker builder files and updates the Dockerfile to copy the binary from the install directory. Feedback was provided on build_openroad.sh regarding the parsing of --openroad-args, suggesting the use of eval to prevent issues with backslash stripping and quote handling associated with the current xargs implementation.
The builder stage ran the OpenROAD installer with -bazel before build_openroad.sh. That step runs apt-get update inside the builder image. On the CI Docker hosts, apt could not create its temporary file under /tmp, and the image build failed. The dev image already runs apt to install every other base dependency. Bazel is now part of -base and -all in the ORFS installer, so bazelisk and its runtime libraries land in the dev image. The dev image tag changes with the installer, so CI rebuilds it. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 8 with regression(s), 0 without a comparable baseline. ❌ asap7/riscv32i base — 2 failing metric(s)
❌ ihp-sg13g2/riscv32i base — 2 failing metric(s)
❌ nangate45/mempool_group base — 1 failing metric(s)
❌ sky130hd/aes base — 1 failing metric(s)
❌ sky130hd/chameleon base — 1 failing metric(s)
❌ sky130hd/microwatt base — 1 failing metric(s)
❌ sky130hd/riscv32i base — 3 failing metric(s)
❌ sky130hs/ibex base — 1 failing metric(s)
|
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
The Bazel build defaults to -O2 without LTO. The CMake RELEASE build used -O3 with LTO. The two binaries give different QoR from CTS onward, and CI compared the Bazel binary against a CMake baseline. Pass -lto so Build.sh uses --config=opt and the binary is closer to the previous one. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
The parser used xargs, which removes backslashes. A path such as C:\projects became C:projects. A pure-bash tokenizer now splits the string. Quotes still group one argument that holds spaces. Every other character stays literal, and nothing is expanded. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
3000fc7
into
The-OpenROAD-Project:master
OpenROAD Build.sh owns both compilation and installation. Remove the CMake-only argument path and use its Bazel install prefix in the ORFS images.