Skip to content

Enable operator mapping to be tuned - #4530

Merged
eder-matheus merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:operator-mapping-at
Sep 11, 2026
Merged

eder-matheus merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:operator-mapping-at

Conversation

@jeffng-or

Copy link
Copy Markdown
Contributor

Also, added log_cmd to operator mapping conditional sections

Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
@jeffng-or jeffng-or self-assigned this Sep 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces logging wrappers using log_cmd in synthesis and resizing scripts, and marks several variables as tunable in the configuration files. The review feedback suggests removing the log_cmd wrapper from the source command in synth.tcl to maintain consistency and ensure proper logging of internal commands. Additionally, it is recommended to also mark SYNTH_WRAPPED_ADDERS and SYNTH_WRAPPED_MULTIPLIERS as tunable to fully support operator mapping tuning.

Comment thread flow/scripts/synth.tcl
[env_var_equals SWAP_ARITH_OPERATORS 1]
} {
source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl
log_cmd source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Wrapping the source command in log_cmd is inconsistent with how other scripts are sourced in the flow (e.g., synth_preamble.tcl or load.tcl). Additionally, log_cmd only logs the source command itself, but does not log the individual Yosys commands executed inside synth_wrap_operators.tcl (such as techmap, wrapcell, opt, etc.).

To maintain consistency and ensure proper logging of the actual synthesis steps, consider leaving the source command unwrapped, and instead wrap the major commands inside synth_wrap_operators.tcl with log_cmd if detailed logging of those steps is desired.

  source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl

Comment on lines +473 to 474
tunable: 1
SYNTH_WRAPPED_ADDERS:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the goal of this PR is to enable operator mapping to be tuned, the variables SYNTH_WRAPPED_ADDERS and SYNTH_WRAPPED_MULTIPLIERS should also be marked as tunable: 1. These variables directly control the architectural choices for the wrapped operators being mapped, and tuning them is highly relevant to optimizing the operator mapping.

Please also apply this change to SYNTH_WRAPPED_MULTIPLIERS in both variables.yaml and variables.json.

  tunable: 1
SYNTH_WRAPPED_ADDERS:
  tunable: 1

@jeffng-or
jeffng-or requested a review from maliberty September 11, 2026 00:42
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check.

Commit 01b512c · Jenkins build #1 · Baseline: build

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
Design Variant Verdict local vs inline passed / failed / missing
asap7/aes base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/aes-block base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/aes-mbff base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/aes_lvt base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/cva6 base ✅ pass ✅ MATCH 12 / 0 / 0
asap7/ethmac base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/ethmac_lvt base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/gcd base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/gcd-ccs base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/ibex base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/jpeg base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/jpeg_lvt base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/mock-alu base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/mock-cpu base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/riscv32i base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/riscv32i-mock-sram base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/swerv_wrapper base ✅ pass ✅ MATCH 25 / 0 / 0
asap7/uart base ✅ pass ✅ MATCH 25 / 0 / 0
gf180/aes base ✅ pass ✅ MATCH 25 / 0 / 0
gf180/aes-hybrid base ✅ pass ✅ MATCH 25 / 0 / 0
gf180/ibex base ✅ pass ✅ MATCH 25 / 0 / 0
gf180/jpeg base ✅ pass ✅ MATCH 25 / 0 / 0
gf180/riscv32i base ✅ pass ✅ MATCH 25 / 0 / 0
gf180/uart-blocks base ✅ pass ✅ MATCH 25 / 0 / 0
gt2n/aes base ✅ pass ✅ MATCH 25 / 0 / 0
gt2n/gcd base ✅ pass ✅ MATCH 25 / 0 / 0
gt2n/jpeg base ✅ pass ✅ MATCH 25 / 0 / 0
ihp-sg13g2/aes base ✅ pass ✅ MATCH 25 / 0 / 0
ihp-sg13g2/gcd base ✅ pass ✅ MATCH 25 / 0 / 0
ihp-sg13g2/i2c-gpio-expander base ✅ pass ✅ MATCH 25 / 0 / 0
ihp-sg13g2/ibex base ✅ pass ✅ MATCH 25 / 0 / 0
ihp-sg13g2/jpeg base ✅ pass ✅ MATCH 25 / 0 / 0
ihp-sg13g2/riscv32i base ✅ pass ✅ MATCH 25 / 0 / 0
ihp-sg13g2/spi base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/aes base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/ariane133 base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/ariane136 base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/black_parrot base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/bp_be_top base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/bp_fe_top base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/bp_multi_top base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/cva6 base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/dynamic_node base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/gcd base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/ibex base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/jpeg base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/mempool_group base ✅ pass ✅ MATCH 12 / 0 / 0
nangate45/swerv base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/swerv_wrapper base ✅ pass ✅ MATCH 25 / 0 / 0
nangate45/tinyRocket base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hd/aes base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hd/chameleon base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hd/gcd base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hd/ibex base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hd/jpeg base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hd/microwatt base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hd/riscv32i base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hs/aes base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hs/gcd base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hs/ibex base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hs/jpeg base ✅ pass ✅ MATCH 25 / 0 / 0
sky130hs/riscv32i base ✅ pass ✅ MATCH 25 / 0 / 0

@jeffng-or

jeffng-or commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor Author

@eder-matheus , sorry, I meant to add you to the public version of this PR.

@eder-matheus
eder-matheus merged commit ef7fbfb into The-OpenROAD-Project:master Sep 11, 2026
12 checks passed
@eder-matheus
eder-matheus deleted the operator-mapping-at branch September 11, 2026 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants