Repository navigation
Enable operator mapping to be tuned - #4530
eder-matheus merged 1 commit into
Conversation
Signed-off-by: Jeff Ng <jeffng@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request introduces logging wrappers using log_cmd in synthesis and resizing scripts, and marks several variables as tunable in the configuration files. The review feedback suggests removing the log_cmd wrapper from the source command in synth.tcl to maintain consistency and ensure proper logging of internal commands. Additionally, it is recommended to also mark SYNTH_WRAPPED_ADDERS and SYNTH_WRAPPED_MULTIPLIERS as tunable to fully support operator mapping tuning.
| [env_var_equals SWAP_ARITH_OPERATORS 1] | ||
| } { | ||
| source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl | ||
| log_cmd source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl |
There was a problem hiding this comment.
Wrapping the source command in log_cmd is inconsistent with how other scripts are sourced in the flow (e.g., synth_preamble.tcl or load.tcl). Additionally, log_cmd only logs the source command itself, but does not log the individual Yosys commands executed inside synth_wrap_operators.tcl (such as techmap, wrapcell, opt, etc.).
To maintain consistency and ensure proper logging of the actual synthesis steps, consider leaving the source command unwrapped, and instead wrap the major commands inside synth_wrap_operators.tcl with log_cmd if detailed logging of those steps is desired.
source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl
| tunable: 1 | ||
| SYNTH_WRAPPED_ADDERS: |
There was a problem hiding this comment.
Since the goal of this PR is to enable operator mapping to be tuned, the variables SYNTH_WRAPPED_ADDERS and SYNTH_WRAPPED_MULTIPLIERS should also be marked as tunable: 1. These variables directly control the architectural choices for the wrapped operators being mapped, and tuning them is highly relevant to optimizing the operator mapping.
Please also apply this change to SYNTH_WRAPPED_MULTIPLIERS in both variables.yaml and variables.json.
tunable: 1
SYNTH_WRAPPED_ADDERS:
tunable: 1
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
|
@eder-matheus , sorry, I meant to add you to the public version of this PR. |
Also, added log_cmd to operator mapping conditional sections