Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flow/scripts/resize.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ if { [env_var_exists_and_non_empty EARLY_SIZING_CAP_RATIO] } {
if { [env_var_equals SWAP_ARITH_OPERATORS 1] } {
# Enable sanity checker until replace_arith_modules becomes stable
set_debug_level ODB replace_design_check_sanity 1
replace_arith_modules
global_placement -incremental
log_cmd replace_arith_modules
log_cmd global_placement -incremental
}

repair_design_helper
Expand Down
2 changes: 1 addition & 1 deletion flow/scripts/synth.tcl
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ if {
[env_var_equals SYNTH_WRAPPED_OPERATORS 1] ||
[env_var_equals SWAP_ARITH_OPERATORS 1]
} {
source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl
log_cmd source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Wrapping the source command in log_cmd is inconsistent with how other scripts are sourced in the flow (e.g., synth_preamble.tcl or load.tcl). Additionally, log_cmd only logs the source command itself, but does not log the individual Yosys commands executed inside synth_wrap_operators.tcl (such as techmap, wrapcell, opt, etc.).

To maintain consistency and ensure proper logging of the actual synthesis steps, consider leaving the source command unwrapped, and instead wrap the major commands inside synth_wrap_operators.tcl with log_cmd if detailed logging of those steps is desired.

  source $::env(SCRIPTS_DIR)/synth_wrap_operators.tcl

} else {
synth -top $::env(DESIGN_NAME) -run fine: -noabc {*}$synth_full_args
}
Expand Down
15 changes: 10 additions & 5 deletions flow/scripts/variables.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions flow/scripts/variables.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@ SYNTH_HIERARCHICAL:
stages:
- synth
default: 0
tunable: 1
SYNTH_USE_SYN:
description: >
If set to 1, run synthesis using the "syn" tool built into OpenROAD
Expand Down Expand Up @@ -273,6 +274,7 @@ SYNTH_HDL_FRONTEND:
command.
stages:
- synth
tunable: 1
SYNTH_SLANG_ARGS:
description: >
Additional arguments passed to the slang frontend during synthesis.
Expand Down Expand Up @@ -468,6 +470,7 @@ SYNTH_WRAPPED_OPERATORS:
stages:
- All stages
default: 0
tunable: 1
SYNTH_WRAPPED_ADDERS:
Comment on lines +473 to 474

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since the goal of this PR is to enable operator mapping to be tuned, the variables SYNTH_WRAPPED_ADDERS and SYNTH_WRAPPED_MULTIPLIERS should also be marked as tunable: 1. These variables directly control the architectural choices for the wrapped operators being mapped, and tuning them is highly relevant to optimizing the operator mapping.

Please also apply this change to SYNTH_WRAPPED_MULTIPLIERS in both variables.yaml and variables.json.

  tunable: 1
SYNTH_WRAPPED_ADDERS:
  tunable: 1

description: >
Specify the adder modules that can be used for synthesis, separated by commas.
Expand All @@ -486,6 +489,7 @@ SWAP_ARITH_OPERATORS:
stages:
- All stages
default: 0
tunable: 1
FLOORPLAN_DEF:
description: |
Use the DEF file to initialize floorplan. Mutually exclusive with FOOTPRINT or DIE_AREA/CORE_AREA or CORE_UTILIZATION.
Expand Down Expand Up @@ -1589,6 +1593,7 @@ OPENROAD_HIERARCHICAL:
otherwise considered flat. Will eventually be the default and
this option will be retired.
default: 0
tunable: 1
stages:
- All stages
NUM_CORES:
Expand Down