Skip to content

[DO NOT MERGE] test inline check PR - #4536

Closed
migueldalberto wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:enforce-inline-check
Closed

migueldalberto wants to merge 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:enforce-inline-check

Conversation

@migueldalberto

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Miguel Dalberto Pedro <miguel.pedro@precisioninno.com>
@migueldalberto migueldalberto self-assigned this Sep 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Jenkinsfile to reference a feature branch ('enforce-inline-check-local-log-only') instead of the 'main' branch for the Jenkins shared library. The reviewer advises against referencing a feature branch as it can lead to unstable or non-reproducible builds, recommending the use of a stable version tag or the 'main' branch instead.

Comment thread Jenkinsfile
@@ -1,4 +1,4 @@
@Library('utils@main') _
@Library('utils@enforce-inline-check-local-log-only') _

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Referencing a feature branch (enforce-inline-check-local-log-only) in the Jenkins shared library can lead to unstable or non-reproducible builds if the branch is modified or deleted. It is recommended to use a stable version tag or the main branch for production pipelines.

@Library('utils@main') _

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit d3267c8 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@migueldalberto
migueldalberto deleted the enforce-inline-check branch September 14, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants