Skip to content

Secure gpl convergence fixes - #4537

Merged
maliberty merged 5 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-gpl-convergence-fixes
Sep 15, 2026
Merged

maliberty merged 5 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-gpl-convergence-fixes

Conversation

@maliberty

@maliberty maliberty commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
…nce-fixes

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
…nce-fixes

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty self-assigned this Sep 14, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the subproject commit for tools/OpenROAD to 90e29809c3d41f5ad289576e4c0c05b80c700bcd. I have no further feedback to provide.

@openroad-ci

openroad-ci commented Sep 14, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 7fe00e5 · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 16 with regression(s), 0 without a comparable baseline.

❌ asap7/cva6 base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -438.029 -4.442 9761.076091850518% -186.442 PeriodPadding 20%
finish__timing__setup__tns -668.687 -10.7352 6128.919815187421% -192.7352 PeriodPadding 20%
globalroute__timing__setup__tns -902.691 -198.504 354.747007616975% -380.504 PeriodPadding 20%
❌ asap7/mock-alu base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -18470.4 -17559.3 5.188703422118194% -17619.3 PeriodPadding 20%
finish__timing__setup__tns -18292.7 -17851.6 2.4709269757332675% -17911.6 PeriodPadding 20%
globalroute__timing__setup__tns -19920.3 -19138 4.087678963319051% -19198.0 PeriodPadding 20%
❌ gf180/aes base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -91.2994 -85.1172 7.2631618521285946% -85.7172 PeriodPadding 20%
finish__timing__setup__tns -99.8359 -95.9916 4.004829589255727% -96.5916 PeriodPadding 20%
globalroute__timing__setup__tns -101.997 -99.3409 2.673722505030657% -99.9409 PeriodPadding 20%
❌ gf180/ibex base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -1283.25 -1274.76 0.6660077191000658% -1276.36 PeriodPadding 20%
finish__timing__setup__tns -1477.29 -1456.3 1.4413239030419556% -1457.9 PeriodPadding 20%
globalroute__timing__setup__tns -1511.77 -1492.5 1.2911222780569513% -1494.1 PeriodPadding 20%
❌ gf180/jpeg base — 2 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -42.383 -0.0685194 61755.47450794958% -1.2685194 PeriodPadding 20%
cts__timing__setup__ws -0.563169 -0.0327058 1621.923940096252% -0.3327058 PeriodPadding 5.0%
❌ gf180/riscv32i base — 2 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -79.9089 -2.28705 3393.9725847707746% -4.08705 PeriodPadding 20%
globalroute__timing__setup__tns -82.0907 -2.62605 3026.014356162297% -4.42605 PeriodPadding 20%
❌ ihp-sg13g2/aes base — 2 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -62.0879 -55.9021 11.065416147157263% -56.3021 PeriodPadding 20%
finish__timing__setup__tns -71.3493 -70.1349 1.7315202559638638% -70.5349 PeriodPadding 20%
❌ nangate45/bp_fe_top base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -3.00049 -1.79813 66.86724541607114% -2.12213 PeriodPadding 20%
finish__timing__setup__tns -5.00009 -2.6412 89.31129789489626% -2.9652 PeriodPadding 20%
globalroute__timing__setup__tns -4.0914 -2.04639 99.93256417398443% -2.37039 PeriodPadding 20%
❌ nangate45/ibex base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -11.6393 -0.122099 9432.674305276865% -0.562099 PeriodPadding 20%
❌ nangate45/mempool_group base — 2 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -11868.6 -11521.7 3.0108404141749916% -11522.3 PeriodPadding 20%
globalroute__timing__setup__tns -11800.3 -11791.2 0.07717619919940294% -11791.8 PeriodPadding 20%
❌ nangate45/swerv base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -440.291 -351.716 25.183670916307474% -352.066 PeriodPadding 20%
finish__timing__setup__tns -532.384 -386.646 37.69287668823679% -386.996 PeriodPadding 20%
globalroute__timing__setup__tns -529.079 -382.723 38.24071195094102% -383.073 PeriodPadding 20%
❌ nangate45/swerv_wrapper base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -408.488 -381.54 7.062955391308906% -381.94 PeriodPadding 20%
finish__timing__setup__tns -360.421 -330.207 9.150018019000203% -330.607 PeriodPadding 20%
globalroute__timing__setup__tns -382.164 -360.984 5.8672960574429895% -361.384 PeriodPadding 20%
❌ sky130hd/chameleon base — 1 failing metric(s)
Metric target base delta limit band
detailedroute__antenna__violating__nets 1 0 — 0.0 Padding 30%
❌ sky130hd/microwatt base — 5 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -253.488 -222.861 13.742646761882968% -225.861 PeriodPadding 20%
detailedroute__antenna_diodes_count 1642 1550 5.935483870967742% 1551.55 Metric 0.1%
finish__timing__setup__tns -195.925 -167.949 16.65743767453215% -170.949 PeriodPadding 20%
globalroute__antenna_diodes_count 3095 3058 1.209941137998692% 3061.058 Metric 0.1%
globalroute__timing__setup__tns -242.772 -204.738 18.576912932626087% -207.738 PeriodPadding 20%
❌ sky130hs/gcd base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -6.74268 -6.18423 9.030226883540877% -6.46423 PeriodPadding 20%
finish__timing__setup__tns -8.65023 -7.66664 12.829479406884893% -7.94664 PeriodPadding 20%
globalroute__timing__setup__tns -13.4289 -11.7697 14.0972157319218% -12.0497 PeriodPadding 20%
❌ sky130hs/jpeg base — 1 failing metric(s)
Metric target base delta limit band
detailedroute__antenna__violating__nets 2 0 — 0.0 Padding 30%

@maliberty maliberty added the UpdateRules Starts GHA to update rules label Sep 14, 2026
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__tns                       |   -83300.0 |   -84400.0 | Failing  |
| globalroute__timing__setup__ws                |     -150.0 |     -147.0 | Tighten  |
| globalroute__timing__setup__tns               |   -74900.0 |   -66000.0 | Tighten  |
| detailedroute__route__wirelength              |     268129 |     267338 | Tighten  |
| finish__timing__setup__ws                     |     -126.0 |     -118.0 | Tighten  |
| finish__timing__setup__tns                    |   -40300.0 |   -35800.0 | Tighten  |
| finish__design__instance__area                |      15300 |      15244 | Tighten  |

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__tns                       |      -56.3 |      -62.5 | Failing  |
| globalroute__timing__setup__ws                |     -0.819 |     -0.769 | Tighten  |
| globalroute__timing__setup__tns               |      -93.7 |      -93.2 | Tighten  |
| finish__timing__setup__ws                     |     -0.775 |     -0.718 | Tighten  |
| finish__timing__setup__tns                    |      -70.5 |      -71.7 | Failing  |
| finish__design__instance__area                |     238519 |     237093 | Tighten  |

designs/sky130hd/chameleon/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__ws                        |      -3.38 |     -0.409 | Tighten  |
| cts__timing__setup__tns                       |     -276.0 |      -8.03 | Tighten  |
| globalroute__antenna_diodes_count             |        196 |        110 | Tighten  |
| globalroute__timing__setup__ws                |      -3.21 |     -0.377 | Tighten  |
| globalroute__timing__setup__tns               |     -180.0 |      -6.57 | Tighten  |
| detailedroute__route__wirelength              |     851647 |     820561 | Tighten  |
| detailedroute__antenna__violating__nets       |          0 |          1 | Failing  |
| detailedroute__antenna_diodes_count           |        150 |        129 | Tighten  |
| finish__timing__setup__ws                     |      -2.88 |     -0.287 | Tighten  |
| finish__timing__setup__tns                    |     -165.0 |      -2.67 | Tighten  |

designs/asap7/cva6/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__tns                       |     -200.0 |     -620.0 | Failing  |
| globalroute__timing__setup__tns               |    -1480.0 |    -1080.0 | Tighten  |
| detailedroute__route__wirelength              |     688855 |     676543 | Tighten  |
| finish__timing__setup__tns                    |    -1330.0 |     -851.0 | Tighten  |

designs/gf180/ibex/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__tns                       |    -1280.0 |    -1540.0 | Failing  |
| finish__timing__setup__tns                    |    -1460.0 |    -1480.0 | Failing  |

designs/nangate45/ibex/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| finish__timing__setup__tns                    |      -1.81 |      -12.1 | Failing  |

designs/gf180/jpeg/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__ws                        |       -0.3 |     -0.863 | Failing  |
| cts__timing__setup__tns                       |       -1.2 |      -43.6 | Failing  |
| globalroute__timing__setup__ws                |     -0.368 |     -0.302 | Tighten  |
| globalroute__timing__setup__tns               |      -1.28 |       -1.2 | Tighten  |
| detailedroute__route__wirelength              |    3169468 |    2834291 | Tighten  |
| finish__timing__setup__ws                     |     -0.523 |      -0.33 | Tighten  |
| finish__timing__setup__tns                    |       -2.2 |      -1.33 | Tighten  |

designs/sky130hd/jpeg/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__ws                        |     -0.961 |     -0.941 | Tighten  |
| cts__timing__setup__tns                       |     -159.0 |     -113.0 | Tighten  |
| globalroute__timing__setup__tns               |     -225.0 |     -142.0 | Tighten  |
| finish__timing__setup__ws                     |     -0.654 |     -0.931 | Failing  |
| finish__timing__setup__tns                    |     -111.0 |      -82.3 | Tighten  |

designs/sky130hs/jpeg/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__ws                        |     -0.528 |     -0.384 | Tighten  |
| cts__timing__setup__tns                       |      -71.6 |      -32.8 | Tighten  |
| globalroute__antenna_diodes_count             |        311 |        100 | Tighten  |
| globalroute__timing__setup__ws                |     -0.761 |     -0.595 | Tighten  |
| globalroute__timing__setup__tns               |     -211.0 |     -141.0 | Tighten  |
| detailedroute__route__wirelength              |    1949870 |    1774465 | Tighten  |
| detailedroute__antenna__violating__nets       |          0 |          3 | Failing  |
| detailedroute__antenna_diodes_count           |        119 |        100 | Tighten  |
| finish__timing__setup__ws                     |     -0.694 |     -0.528 | Tighten  |
| finish__timing__setup__tns                    |     -108.0 |      -44.9 | Tighten  |

designs/sky130hd/microwatt/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| cts__timing__setup__tns                       |     -226.0 |     -256.0 | Failing  |
| globalroute__antenna_diodes_count             |       3061 |       3098 | Failing  |
| globalroute__timing__setup__tns               |     -208.0 |     -246.0 | Failing  |
| detailedroute__antenna__violating__nets       |        120 |         81 | Tighten  |
| detailedroute__antenna_diodes_count           |       1552 |       1644 | Failing  |
| finish__timing__setup__tns                    |     -171.0 |     -199.0 | Failing  |

designs/gf180/riscv32i/rules-base.json updates:
| Metric                                        | Old        | New        | Type     |
| ------                                        | ---        | ---        | ----     |
| globalroute__timing__setup__tns               |      -10.1 |      -83.9 | Failing  |
| finish__timing__setup__tns                    |      -9.95 |      -81.7 | Failing  |

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty
maliberty merged commit aabf2a3 into The-OpenROAD-Project:master Sep 15, 2026
10 of 12 checks passed
@maliberty
maliberty deleted the secure-gpl-convergence-fixes branch September 15, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

UpdateRules Starts GHA to update rules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants