Skip to content

Remove REMOVE_ABC_BUFFERS support - #4580

Merged
maliberty merged 4 commits into
The-OpenROAD-Project:masterfrom
oharboe:remove-abc-buffers-support
Oct 21, 2026
Merged

maliberty merged 4 commits into
The-OpenROAD-Project:masterfrom
oharboe:remove-abc-buffers-support

Conversation

@oharboe

@oharboe oharboe commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator

TL;DR removes REMOVE_ABC_BUFFERS completely from the repository, ready for review.

Single-concern PR: remove all REMOVE_ABC_BUFFERS support from the flow, documentation and designs.

  • floorplan.tcl always runs repair_timing_helper, and the remove_buffers branch is gone.
  • Removed from variables.yaml, and variables.json and docs/user/FlowVariables.md were regenerated.
  • Removed the last design use in flow/designs/asap7/picorv32/config.mk.

After this PR, git grep -i REMOVE_ABC_BUFFERS is empty.

Prerequisite design updates, all merged: #4575, #4576, #4577, #4578, #4579.

🤖 Generated with Claude Code

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the deprecated REMOVE_ABC_BUFFERS configuration variable from the documentation, variable schemas, and scripts. In floorplan.tcl, setting this variable now raises an error indicating it is no longer supported, and the timing repair helper is executed unconditionally. Feedback on the changes suggests improving the Tcl conditional check for REMOVE_ABC_BUFFERS to robustly handle non-numeric boolean strings (like 'false' or 'no') to avoid triggering false-positive errors.

Comment thread flow/scripts/floorplan.tcl Resolved
floorplan.tcl now always runs repair_timing_helper. The variable is
dropped from variables.yaml, variables.json and FlowVariables.md.

Designs are deliberately not touched here; they are handled by
The-OpenROAD-Project#4575, The-OpenROAD-Project#4576, The-OpenROAD-Project#4577, The-OpenROAD-Project#4578 and The-OpenROAD-Project#4579.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe force-pushed the remove-abc-buffers-support branch from 546f50c to 12f3cfb Compare September 29, 2026 05:45
@oharboe
oharboe requested a review from maliberty September 29, 2026 05:45
@openroad-ci

openroad-ci commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 6ca8338 · Jenkins build #8 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 1 without a comparable baseline.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

# Conflicts:
#	docs/user/FlowVariables.md
#	flow/scripts/variables.json
#	flow/scripts/variables.yaml
@maliberty

Copy link
Copy Markdown
Member

You have missed

designs/asap7/picorv32/config.mk:11:export REMOVE_ABC_BUFFERS = 1

oharboe and others added 2 commits October 13, 2026 20:54
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe

oharboe commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

Fixed in 2862c18, git grep -i REMOVE_ABC_BUFFERS is now empty.

@maliberty

Copy link
Copy Markdown
Member

@ahmed532 has come up with some AT results where REMOVE_ABC_BUFFERS=1 helps a good amount (private PDK/test case). More study is needed before this can be approved.

@oharboe

oharboe commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

@maliberty @ahmed532 thanks. I'm curious about the AT result. Is AT AutoTuner, how many runs, and what was varied?

Jeong and Kahng, "Methodology From Chaos in IC Implementation" (ISQED 2010), found that "negligibly small input parameter changes can result in substantially different design outcomes." That was with commercial tools, not OpenROAD. Still, it suggests one measurement without a sweep isn't necessarily a signal.

Could REMOVE_ABC_BUFFERS be acting like a seed change here? I haven't tested that.

I can't access the test case, so I can't investigate it and there's nothing I can do to move this forward. Could we track the AT case in an issue (a private one if needed) and merge this?

Supported alternatives:

  • SETUP_SLACK_MARGIN: stops floorplan repair_timing early. It's tunable for AutoTuner.
  • TNS_END_PERCENT: limits how many violating endpoints repair_timing fixes.
  • ABC_SCRIPT: use your own ABC script, for example without buffer -c.
  • POST_FLOORPLAN_TCL: run remove_buffers after repair_timing. This is not the same as the old behavior.

@maliberty
maliberty merged commit 31ae82d into The-OpenROAD-Project:master Oct 21, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants