Repository navigation
Remove REMOVE_ABC_BUFFERS support - #4580
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the deprecated REMOVE_ABC_BUFFERS configuration variable from the documentation, variable schemas, and scripts. In floorplan.tcl, setting this variable now raises an error indicating it is no longer supported, and the timing repair helper is executed unconditionally. Feedback on the changes suggests improving the Tcl conditional check for REMOVE_ABC_BUFFERS to robustly handle non-numeric boolean strings (like 'false' or 'no') to avoid triggering false-positive errors.
floorplan.tcl now always runs repair_timing_helper. The variable is dropped from variables.yaml, variables.json and FlowVariables.md. Designs are deliberately not touched here; they are handled by The-OpenROAD-Project#4575, The-OpenROAD-Project#4576, The-OpenROAD-Project#4577, The-OpenROAD-Project#4578 and The-OpenROAD-Project#4579. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
546f50c to
12f3cfb
Compare
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 1 without a comparable baseline. |
Signed-off-by: Matt Liberty <mliberty@precisioninno.com> # Conflicts: # docs/user/FlowVariables.md # flow/scripts/variables.json # flow/scripts/variables.yaml
|
You have missed designs/asap7/picorv32/config.mk:11:export REMOVE_ABC_BUFFERS = 1 |
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
Fixed in 2862c18, |
|
@ahmed532 has come up with some AT results where REMOVE_ABC_BUFFERS=1 helps a good amount (private PDK/test case). More study is needed before this can be approved. |
|
@maliberty @ahmed532 thanks. I'm curious about the AT result. Is AT AutoTuner, how many runs, and what was varied? Jeong and Kahng, "Methodology From Chaos in IC Implementation" (ISQED 2010), found that "negligibly small input parameter changes can result in substantially different design outcomes." That was with commercial tools, not OpenROAD. Still, it suggests one measurement without a sweep isn't necessarily a signal. Could I can't access the test case, so I can't investigate it and there's nothing I can do to move this forward. Could we track the AT case in an issue (a private one if needed) and merge this? Supported alternatives:
|
TL;DR removes REMOVE_ABC_BUFFERS completely from the repository, ready for review.
Single-concern PR: remove all
REMOVE_ABC_BUFFERSsupport from the flow, documentation and designs.floorplan.tclalways runsrepair_timing_helper, and theremove_buffersbranch is gone.variables.yaml, andvariables.jsonanddocs/user/FlowVariables.mdwere regenerated.flow/designs/asap7/picorv32/config.mk.After this PR,
git grep -i REMOVE_ABC_BUFFERSis empty.Prerequisite design updates, all merged: #4575, #4576, #4577, #4578, #4579.
🤖 Generated with Claude Code