Repository navigation
Conversation
Build.sh always uses --config=release, which already includes --config=opt. -lto added --config=opt a second time, so every compile got -O3 twice, which changed every action key. The Docker builder stage then missed the remote cache that OpenROAD CI fills with --config=ci and rebuilt OpenROAD from scratch. The binary is unchanged: it is still built with -O3 and ThinLTO. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the build_openroad.sh script by removing the -lto flag from OPENROAD_APP_ARGS and updating the comments to clarify that Build.sh now always builds with Bazel --config=release (which includes -O3 and ThinLTO). There are no review comments, so I have no additional feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenROAD's
Build.shalways builds with Bazel--config=release, which already includes--config=opt(-O3 and ThinLTO). Passing-ltoadded--config=opta second time, so Bazel expandedopttwice (WARNING: The following configs were expanded more than once: [opt]) and every compile got-O3twice.That changes every CppCompile action key, so the "Make Docker image w/binaries" stage never hit the remote cache that OpenROAD CI fills with
--config=ciand rebuilt all ~18k actions from scratch.bazel aqueryaction keys forsrc/odb/src/db/tmg_conn.cpp:-O3count--config=cid31d96fc…--config=release --//:platform=guid31d96fc…--config=release --config=opt(with-lto)d1256c59…The pinned OpenROAD already has
build:release --config=opt, so the binary is still built with -O3 and ThinLTO. The companion OpenROAD change (The-OpenROAD-Project-private/OpenROAD#3844) makes-ltoa no-op inBuild.sh.