Skip to content

make: remove unused exported variable - #4590

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
gtkiku:unused-var
Oct 2, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
gtkiku:unused-var

Conversation

@gtkiku

@gtkiku gtkiku commented Sep 30, 2026

Copy link
Copy Markdown
Contributor

Previous PR from which this was split: #4573

@oharboe

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused KLAYOUT_ENV_VAR_IN_PATH variable from flow/scripts/variables.mk. The review feedback suggests also removing the now-unused KLAYOUT_ENV_VAR_IN_PATH_VERSION variable and its associated comments to keep the codebase clean.

Comment thread flow/scripts/variables.mk Resolved
Signed-off-by: ctkiku <kim.kuparinen@tuni.fi>
@openroad-ci

openroad-ci commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit cea12ab · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@maliberty
maliberty merged commit cd8afe9 into The-OpenROAD-Project:master Oct 2, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants