Skip to content

gpl: Incremental global placement using estimate_target_density - #4594

Merged
vvbandeira merged 4 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-gpl-incremental
Oct 5, 2026
Merged

vvbandeira merged 4 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:secure-gpl-incremental

Conversation

@LucasYuki

Copy link
Copy Markdown
Contributor

Uses estimate_target_density to pick an explicit density for the post-arithmetic-replacement incremental placement, and bumps the OpenROAD submodule for the filler-redistribution and overflow-recovery improvements it depends on.

Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
@LucasYuki LucasYuki self-assigned this Sep 30, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenROAD subproject commit and modifies the resize.tcl script to estimate and apply target density during incremental global placement when arithmetic operator swapping is enabled. The feedback points out that estimate_target_density should be called after replace_arith_modules rather than before, because the latter modifies the netlist and changes the total cell area, which would lead to an inaccurate density target.

Comment thread flow/scripts/resize.tcl Resolved
@openroad-ci

openroad-ci commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 9e86185 · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 9 with regression(s), 0 without a comparable baseline.

❌ asap7/aes-block base — 1 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -2048.78 -1466.48 -39.70732638699471% -1759.776 PeriodPadding 20%
❌ asap7/riscv32i-mock-sram base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -5539.42 -762.664 -626.3250920457764% -952.664 PeriodPadding 20%
❌ gf180/jpeg base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -5.98383 -0.160303 -3632.8247131993785% -1.360303 PeriodPadding 20%
❌ ihp-sg13g2/jpeg base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -28.6404 -21.4754 -33.36375573912476% -25.77048 PeriodPadding 20%
detailedroute__antenna_diodes_count 125 77 62.33766233766234% 100 Metric 0.1%
globalroute__timing__setup__tns -74.3983 -48.242 -54.218937854981135% -57.8904 PeriodPadding 20%
❌ nangate45/ibex base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -2.69773 -0.210899 -1179.15732175117% -0.650899 PeriodPadding 20%
❌ nangate45/tinyRocket base — 2 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -26.0002 -13.6048 -91.1104904151476% -16.32576 PeriodPadding 20%
finish__timing__setup__tns -28.0082 -20.1688 -38.86894609495855% -24.20256 PeriodPadding 20%
❌ sky130hd/chameleon base — 4 failing metric(s)
Metric target base delta limit band
cts__timing__setup__ws -0.612817 -0.424929 -44.216327904191054% -0.574929 PeriodPadding 5.0%
detailedroute__antenna_diodes_count 114 63 80.95238095238095% 100 Metric 0.1%
globalroute__timing__setup__tns -14.9995 -12.3447 -21.50558539292166% -14.81364 PeriodPadding 20%
globalroute__timing__setup__ws -0.531374 -0.359319 -47.88363543258219% -0.509319 PeriodPadding 5.0%
❌ sky130hd/riscv32i base — 2 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -35.4658 -20.5919 -72.23179988247806% -24.71028 PeriodPadding 20%
globalroute__timing__setup__tns -105.952 -59.9419 -76.75782716263582% -71.93028 PeriodPadding 20%
❌ sky130hs/riscv32i base — 2 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -127.616 -79.3481 -60.83056809173755% -95.21772 PeriodPadding 20%
finish__timing__setup__tns -215.215 -174.4 -23.40309633027523% -209.28 PeriodPadding 20%

@LucasYuki
LucasYuki requested a review from gudeh October 1, 2026 14:29
Comment thread flow/scripts/resize.tcl
if { [env_var_equals SWAP_ARITH_OPERATORS 1] } {
# Enable sanity checker until replace_arith_modules becomes stable
set_debug_level ODB replace_design_check_sanity 1
set density [estimate_target_density -overflow 0.1]

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For incremental mode now we estimate the density before calling the incremental command. Isn't 0.1 the target overflow anyway?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the default target overflow.
Do you want me to remove the -overflow argument from this call?

@gudeh

gudeh commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

@LucasYuki conflict

Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
Signed-off-by: LucasYuki <lucasyuki@yahoo.com.br>
@vvbandeira
vvbandeira merged commit babdf6e into The-OpenROAD-Project:master Oct 5, 2026
10 of 12 checks passed
@vvbandeira
vvbandeira deleted the secure-gpl-incremental branch October 5, 2026 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants